Skip to content

docs: ask for bug fix tests that fail without the fix #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anurag629 merged 1 commit into from
Oct 15, 2026
Merged

docs: ask for bug fix tests that fail without the fix #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ Closes #
- [ ] I was assigned the linked issue
- [ ] `npm run check` passes
- [ ] `npm run test` passes
- [ ] For a bug fix: the new test fails without my change
- [ ] Tested locally with `npm run dev`
- [ ] Screenshots included for visual changes
- [ ] New templates follow the [Template Guidelines](https://github.com/codercops/ogcops/blob/dev/CONTRIBUTING.md#template-guidelines)
2 changes: 2 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ Two spam PRs and you won't be assigned more issues this month, and you're out of

Every PR needs a "How I tested this" line: what you ran or clicked through to check it works.

For a bug fix, check that your new test fails without the fix: undo the change in the source, run the tests, then put it back. A test that passes either way doesn't catch anything.

I review most PRs within a few days. Please don't ping repeatedly or DM maintainers about a review. If three days pass with no reply, one follow-up comment on the PR is fine.

### Goodies
Expand Down
Loading