fix: remove forceDevUpdateConfig causing update error in dev mode - #85
Open
Longado wants to merge 1 commit into
Open
fix: remove forceDevUpdateConfig causing update error in dev mode#85Longado wants to merge 1 commit into
Longado wants to merge 1 commit into
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the Contributor License Agreement (CLA) and hereby sign the CLA. |
Author
|
recheck |
Author
|
@yiliushenburke Hi, I've signed the CLA but the bot doesn't seem to have picked it up. The CLA check is still failing. Could you please take a look? Thanks! |
`autoUpdater.forceDevUpdateConfig = true` attempts to read a `dev-app-update.yml` file that does not exist in the repo, causing an update failure dialog every time the app is started in dev mode. Since the `if (app.isPackaged)` branch already guards scheduled update checks, the else branch is unnecessary — simply removing it lets dev mode skip updates silently. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Longado
force-pushed
the
fix/remove-dev-update-config
branch
from
March 31, 2026 02:16
5388580 to
dbef874
Compare
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
autoUpdater.forceDevUpdateConfig = truein theelsebranch ofapp.isPackagedcheck inupdate-manager.tsdev-app-update.ymlfile that does not exist in the repo, causing an update failure dialog on every dev mode launchif (app.isPackaged)guard already ensures update checks only run in production, so theelsebranch is unnecessaryTest plan
bun run devand confirm no update error dialog appearsbun run buildand verify packaged app still checks for updates normally🤖 Generated with Claude Code