Repository navigation
Conversation
Member
Author
|
This is a big enough engineering change that I think it would be good for you to do a manual review. Thank you! |
conatus
commented
Oct 26, 2026
|
|
||
| The workflow fails before releasing if the version in `join.php`, the `Stable tag:` in `readme.txt` and the `release:` in `packages/join-flow/src/index.tsx` disagree, or if `readme.txt` has no changelog entry for the version. Run `./scripts/check-version.sh` to check this locally. | ||
|
|
||
| Don't push tags by hand: a tag push no longer triggers a release, and a hand-made tag would make the workflow skip that version. If a release fails, use "Re-run failed jobs" on the run. Re-running is safe: the deploy skips a version already on WordPress.org, and the tag is only created after the deploy succeeds. |
Member
Author
There was a problem hiding this comment.
Don't write this kind of documentation which says a change occurred. Documentation should detail the current status, not some legacy status that people don't need to know about.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Releases needed a manual tag push after merging the version bump. Merging a PR that bumps the version should be enough to ship it.
How
release-plugin.ymlnow runs on pushes tomaster(and "Run workflow"), not on tag pushes.checkjob runs the newscripts/check-version.sh, which fails ifjoin.php,readme.txtandindex.tsxdisagree on the version orreadme.txthas no changelog entry for it. It then looks for a tag with that version. If the tag exists, every other job is skipped.bump-version.shand the readme no longer tell you to tag.check-version.shhas tests inscripts/check-version.test.sh, run by a newScript Testsworkflow.Manual tag pushes no longer release. I dropped that trigger instead of keeping it as a fallback: a hand-pushed tag racing the master run could deploy twice, and a hand-made tag makes the check skip that version. Re-running the failed jobs is the fallback.
The tag is pushed with
GITHUB_TOKEN, so it starts no other workflow runs. This workflow no longer listens for tags either way.Test plan
Watch out for
concurrency: release-plugin). Pending runs can be superseded, but the newest run checks the latest version, so nothing is lost.🤖 Generated with Claude Code