[conatus]

Third of the settings page regression test PRs. Stacked on #134 (Theme + Copy), which is stacked on #133 (foundation + Features).

Covers every setting on the Membership Plans tab. Each test changes the setting on the settings page, reads it back through Settings::get, and checks it does what the rest of the plugin expects. A legacy test loads the settings as Carbon Fields stored them and checks they still work.

What's covered (tests/settings/membership-plans.spec.ts)

Global plans

• A plan added on the settings page is saved, stored under its ID (ck_join_flow_membership_plan_<id>) and offered on a join form with no plans of its own, with the right price label, description and "Continue and pay" text.
• Each plan field:
  • Price Point ID becomes the plan's ID, and joins use it.
  • Frequency and Currency set how the price is shown. New plans are monthly GBP unless changed.
  • Allow users to change the amount shows an amount box with the price as its minimum. /join also enforces that minimum.
• Removing a plan takes it off the form. Its stored copy is kept, so a form opened earlier can still complete a join.
• A changed price reaches the form and the stored plan.
• Saving is refused with no plans, or with a plan missing its Name or Price, and nothing is saved.
• Stripe (fake API): each plan gets a product, and a recurring price in its currency, amount and frequency (week/month/year). A changed price gets a new price on the same product.

Member tags (fake Stripe and Mailchimp)

• Defaults: "Lapsed - failed payment", "Cancelled", "Lapsing".
• On a join, the plan's Add Tags are added. The lapsed, cancelled and lapsing tags and other plans' tags are removed.
• Stripe webhook events apply the tags:
  • A subscription ended by failed payments gets Lapsed Tag.
  • A subscription the member cancelled gets Cancelled Tag.
  • A failed payment Stripe will retry gets Lapsing Tag.
  • A blank tag turns that tagging off.
• Moving to another plan in Stripe swaps the old plan's Add Tags for the new plan's.

Legacy: plans and tags in Carbon Fields' storage format are still read, offered on the form and can be joined on.

Supporting changes

• JoinSettingsPage: plans(), addPlan(), editPlan(), removePlan(), expectSaveRefused().
• postJoin() and postStripeWebhook() helpers, plus GLOBAL_PLANS_PAGE.
• Fake Stripe: list endpoints, plus a control endpoint for tests to put objects in place first (seedFakeStripe), e.g. the customer a webhook names.
• Docs: coverage table and readme updated.

Problems found

• JOIN-166: saving creates a duplicate Stripe price every time for plans priced in pence (e.g. £9.50). There's a skipped test for it; I checked it fails when enabled.
• JOIN-165 (found while reading the webhook code): the Stripe webhook endpoint doesn't verify Stripe's signature. The tests here post unsigned events, so they'll need signing once that's fixed.

Testing

Locally, all of tests/settings: 89 passed, 5 skipped (the known-problem tests).

---

Generated by Claude Code

[conatus]

Supplementary review: one issue with how expectSaveRefused will behave once the page is rebuilt. This adds to the inline findings already posted.

---

Generated by Claude Code

[linear-code]

JOIN-173