Repository navigation
Conversation
The log holds text sent by visitors (for example the plan ID in a /join request), and was printed into the page as HTML, so markup in it ran in the admin's browser. Show it as text instead. JOIN-168. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BL2bFrTk84JMy3CPAsCTV9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes JOIN-168.
The Logging tab shows the latest plugin log inside a
<pre>, but printed it unescaped. The log holds text visitors send, for example the plan ID from a/joinrequest, so markup sent that way ran in the browser of whichever admin next opened the tab. The fix escapes the log withesc_html(), as the Loggly message just above it already does.Branched from master, separate from the settings test stack (#133 to #138), so it can go out on its own.
Testing
tests/log-viewer.spec.ts: posts a/joinwhose plan ID is an<img onerror>, opens the Logging tab as an admin, and checks the markup is shown as text and never becomes an element or runs. It fails without the fix (the<img>element is created) and passes with it.Generated by Claude Code