Repository navigation
Check a production install in CI, including Wordfence - #304
Merged
Merged
Conversation
mnsami/composer-custom-directory-installer puts Carbon Fields in web/app/vendor/, where its admin scripts and styles can be served. It was a dev dependency, so the deploy's `composer install --no-dev` left it out and installed Carbon Fields in vendor/, outside the web root, and the admin's Carbon Fields assets returned 404. It is now a normal dependency. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H7mTobLooqmmxgZuJYAE8d
A new workflow installs the site the way deploy.yml deploys it: Composer without dev packages, the production theme build, WP_ENV=production and every plugin active, including Wordfence, which development turns off. It runs the plugin, smoke, browser and PHP log checks against that. It found the Carbon Fields install path fixed in the previous commit. To support it: - PHP logs errors to the wordpress container's output, as hosts do, and check-php-log.sh checks that as well as WordPress's debug log, which production doesn't write - The browser tests can run without the dev server (E2E_DEV_SERVER=false), which would otherwise replace the production build in build/ - The browser tests log in once and share the session. A login on a fresh install with Wordfence active failed once in six runs, and couldn't be reproduced, so this cuts logins from three to one - Wordfence's firewall folder is made writable by PHP-FPM, as the runner owns the checkout Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H7mTobLooqmmxgZuJYAE8d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production installs were not covered by CI, so failures specific to Composer installs without development packages, production assets or Wordfence could pass development checks. This adds a production install workflow using the shared checks already on
main.Changes
--no-dev --no-scripts), build production theme assets and setWP_ENV=production.E2E_DEV_SERVER=falsetests the production build without starting the dev server or overwriting its assets.Validation