fix: correct WaitTask inputParameter key from 'wait_until' to 'until' - #467
Open
deeptireddy-lab wants to merge 1 commit into
Open
fix: correct WaitTask inputParameter key from 'wait_until' to 'until'#467deeptireddy-lab wants to merge 1 commit into
deeptireddy-lab wants to merge 1 commit into
Conversation
…#426) WaitTask.__init__() was setting the inputParameter key as "wait_until" but the Conductor server expects "until" (see Wait.java: UNTIL_INPUT = "until"). This caused workflows using WaitTask(wait_until=...) to stay RUNNING indefinitely because the server never evaluated the condition. Also adds unit tests covering WaitTask, WaitForDurationTask, and WaitUntilTask to prevent regressions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #426.
WaitTask.__init__(wait_until=...)was setting theinputParameterkey as"wait_until", but the Conductor server reads"until"(seeWait.java:UNTIL_INPUT = "until"). This caused any workflow usingWaitTask(wait_until=...)directly to stayRUNNING/IN_PROGRESSindefinitely — the server never evaluated the wait condition.wait_task.pyline 25:"wait_until"→"until"WaitTask.__init__()called withwait_until=was affected.WaitUntilTaskalready used the correct key and is unchanged.Changes
src/conductor/client/workflow/task/wait_task.py— fix the wrong key ("wait_until"→"until")tests/unit/workflow/test_wait_task.py— add unit tests forWaitTask,WaitForDurationTask, andWaitUntilTaskto prevent regressionsTest plan
pytest tests/unit/workflow/test_wait_task.py— all 5 tests passWaitTask("ref", wait_until="2025-01-01 00:00 UTC").input_parametersreturns{"until": "2025-01-01 00:00 UTC"}(not"wait_until")WaitUntilTaskandWaitForDurationTaskbehaviour unchanged🤖 Generated with Claude Code