Skip to content

fix: raise next floor and drop stale override pins to resolve Snyk vulnerabilities - #77

Open
cs-raj wants to merge 1 commit into
mainfrom
fix/snyk-patch-deps-20261007
Open

cs-raj wants to merge 1 commit into
mainfrom
fix/snyk-patch-deps-20261007

Conversation

@cs-raj

@cs-raj cs-raj commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Problem

Snyk flags next 16.3.4 (RCE in next/og, SSRF), dompurify 3.4.15 (XSS) and sharp 0.35.4 (use-after-free). The committed lock file is stale, and an earlier cleanup pinned sharp to exactly 0.35.4 in overrides, so the fixed 0.35.5 could never be picked up.

Fix

  • Regenerated package-lock.json from a clean install. That alone clears the next and dompurify findings (next lands on 16.4.0).
  • Raised the next floor to ^16.3.8 so a fresh install can never land on the RCE versions.
  • Removed stale override pins: sharp (was blocking the fix), plus qs, nanoid, undici, js-yaml, which the tree already resolves past. postcss pin kept; it still holds a nested copy above 8.5.23.
  • Version 1.2.3 → 1.2.4.

Result: Snyk real vulns 4 → 0 (the 20 sharp libvips license flags have no fix), npm audit 10 → 5. The remaining npm-audit rows (braces, fast-glob, micromatch, @next/eslint-plugin-next) are open-ended ranges with no fixed version and Snyk does not flag them.

Verified: next build compiles on the new lock file. Prerendering / needs real stack credentials, same as on main.

🤖 Generated with Claude Code

…lnerabilities

Lock file regenerated (cleared the next RCE/SSRF and dompurify XSS on its own).
Direct upgrades: next ^16.3.8
Overrides: removed stale pins sharp, qs, nanoid, undici, js-yaml (postcss kept);
the sharp pin was holding the vulnerable 0.35.4 in place.
Vuln count: snyk 4 -> 0 (20 sharp-libvips license flags unchanged), npm audit 10 -> 5
(remaining are open-ended tooling ranges with no fix). Compiles; prerender needs
real stack credentials, unchanged from main.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@cs-raj
cs-raj requested a review from a team as a code owner October 7, 2026 10:49
@cs-raj cs-raj self-assigned this Oct 7, 2026
@snyk-io

snyk-io Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 0 0 25 ✅ Passed
🟡 Medium Severity 0 20 500 ✅ Passed
🔵 Low Severity 0 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

ℹ️ Vulnerabilities Without Available Fixes (Informational Only)

The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:

  • Critical without fixes: 0
  • High without fixes: 0
  • Medium without fixes: 20
  • Low without fixes: 0

✅ BUILD PASSED - All security checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant