Fix external loggers respecting configured format - #7699
Open
Rohithmatham12 wants to merge 3 commits into
Open
Conversation
dosubot
Bot
added
go
Signed-off-by: Rohithmatham12 <rohithmatham@gmail.com>
Rohithmatham12
force-pushed
the
fix-json-log-format-external-loggers
branch
from
July 18, 2026 17:15
e0e6dac to
9999625
Compare
Signed-off-by: Rohithmatham12 <rohithmatham@gmail.com>
Rohithmatham12
force-pushed
the
fix-json-log-format-external-loggers
branch
from
August 5, 2026 05:09
1fb1c7c to
9a62f5d
Compare
Signed-off-by: Rohithmatham12 <rohithmatham@gmail.com>
Rohithmatham12
force-pushed
the
fix-json-log-format-external-loggers
branch
from
August 5, 2026 17:40
9a62f5d to
1497c2d
Compare
friedrichg
approved these changes
Aug 6, 2026
Member
There was a problem hiding this comment.
I am not sure the automaxprocs package is needed after 1.26.
There is conflicting information uber-go/automaxprocs#98 (comment)
we can decide later after some testing
@Rohithmatham12 good work though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
server.log_format.maxprocs.Set(...)after Cortex initializes logging, so maxprocs messages also use the configured format.GRPC_GO_LOG_SEVERITY_LEVELasks for warning/info.Fixes #7697.
Testing
GOCACHE=/private/tmp/cortex-go-cache GOMODCACHE=/private/tmp/cortex-go-mod-cache go test ./pkg/util/logGOCACHE=/private/tmp/cortex-go-cache GOMODCACHE=/private/tmp/cortex-go-mod-cache go test ./cmd/cortex