fix: eliminate spurious "bucket operation fail after retries" logs during partial block cleanup - #7749
Merged
SungJin1212 merged 3 commits intoAug 6, 2026
Conversation
…ring partial block cleanup Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
friedrichg
reviewed
Aug 4, 2026
| if !IsBlockVisitMarker(file) { | ||
| // return error here to fail iteration fast | ||
| // to avoid going through all files | ||
| return ErrorNotBlockVisitMarker |
Member
There was a problem hiding this comment.
I think ErrorNotBlockVisitMarker and IsNotBlockVisitMarkerError can be removed after this change
Member
Author
There was a problem hiding this comment.
Yeah, I've cleaned up to the latest commit
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
I've noticed spurious error logs during partial block cleanup:
Root cause
cleanUserPartialBlocksreturned a sentinel error (ErrorNotBlockVisitMarker) from theItercallback to fast-fail iteration when a non-visit-marker file was detected. Since the bucket client wrapsBucketWithRetriesinternally, this error triggered 5 retries before logging the error.Fix
Replace the sentinel error pattern with a simple boolean flag (
hasNonVisitMarker). The callback no longer returns an error, so no retries occur.Note: deletion behavior is unchanged, only the spurious retries and error logs are eliminated.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags