CBG-5969: fix staticcheck slice/range nil check warnings - #8518
Open
torcolvin wants to merge 4 commits into
Open
CBG-5969: fix staticcheck slice/range nil check warnings#8518torcolvin wants to merge 4 commits into
torcolvin wants to merge 4 commits into
Conversation
|
Droid finished @torcolvin's task —— View job |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes redundant nil checks around len() and range that are flagged by staticcheck (S1009/S1031), and updates the strict golangci-lint configuration to stop suppressing those checks—aiming to eliminate unskippable gopls/staticcheck warnings in the Sync Gateway Go codebase.
Changes:
- Remove redundant
nilchecks beforelen(slice)calls across REST/DB code paths (S1009). - Remove redundant
nilchecks guardingrangeloops where applicable (S1031). - Update
.golangci-strict.ymlto no longer disable S1009 and S1031.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| rest/doc_api.go | Simplifies empty-body detection by relying on len(nil)==0. |
| db/users.go | Refactors collection access update detection logic (introduces a nil-deref risk as written). |
| db/sg_replicate_cfg.go | Removes redundant nil guards around len() and range. |
| db/revision.go | Simplifies ancestor revision length check via len(nil)==0. |
| db/document.go | Simplifies raw body length check via len(nil)==0. |
| db/changes.go | Simplifies “no late logs” check via len(nil)==0. |
| .golangci-strict.yml | Enables staticcheck S1009 and S1031 by removing their exclusions. |
Comment on lines
+271
to
+275
| for collectionName, updatedCollectionAccess := range scope { | ||
| _, err := dbc.GetDatabaseCollection(scopeName, collectionName) | ||
| if err != nil { | ||
| return false, base.HTTPErrorf(http.StatusNotFound, "keyspace specified in collection_access (%s) not found", fmt.Sprintf("%s.%s.%s", dbc.Name, scopeName, collectionName)) | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
I pushed a bunch of changes for this into this review but ultimately it was a separate long standing problem.
![factory-droid[bot]](https://avatars.githubusercontent.com/in/358017?s=60&v=4){kind=small}
There was a problem hiding this comment.
Most changes are safe mechanical removals of redundant nil checks. One correctness issue: RequiresCollectionAccessUpdate can panic when a collection_access map contains a JSON null value for a collection; the nil check needs to happen before dereferencing read-only fields.
torcolvin
added a commit
that referenced
this pull request
Aug 4, 2026
Move the nil check for updatedCollectionAccess before the read-only field checks so a null collection_access entry (used to delete a collection's explicit channels) no longer panics. Regression caught by review from Copilot and factory-droid on PR #8518. Add TestPutUserCollectionAccessNull to cover the null-entry PUT path.
torcolvin
added a commit
that referenced
this pull request
Aug 4, 2026
Move the nil check for updatedCollectionAccess before the read-only field checks so a null collection_access entry (used to delete a collection's explicit channels) no longer panics. Regression caught by review from Copilot and factory-droid on PR #8518. Add TestPutUserCollectionAccessNull to cover the null-entry PUT path.
Redocly previews |
- Remove redundant slice nil checks prior to calling len() (staticcheck S1009) - Remove redundant nil checks around slice/map range loops (staticcheck S1031)
Move the nil check for updatedCollectionAccess before the read-only field checks so a null collection_access entry (used to delete a collection's explicit channels) no longer panics. Regression caught by review from Copilot and factory-droid on PR #8518. Add TestPutUserCollectionAccessNull to cover the null-entry PUT path.
torcolvin
force-pushed
the
CBG-5969-gopls-nil-slices
branch
from
August 6, 2026 15:48
55034e1 to
81bb57f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CBG-5969: fix staticcheck slice/range nil check warnings
This silences some unskippable gopls warnings without specific user configuration.