docs(compute-plane): link decision 0001 instead of inlining the rationale - #57
Open
myasnikovdaniil wants to merge 1 commit into
Open
docs(compute-plane): link decision 0001 instead of inlining the rationale#57myasnikovdaniil wants to merge 1 commit into
myasnikovdaniil wants to merge 1 commit into
Conversation
…nale The "Revision (this PR)" field carried a paragraph explaining why the preset-field revision was set aside. Post-merge "this PR" no longer refers to anything, and the Overview restates the same material, so the field was a third copy of the rationale with no home of its own. Decision 0001 is that home now. Replace the field with Supersedes plus a link. Assisted-By: Claude <noreply@anthropic.com> Signed-off-by: Myasnikov Daniil <myasnikovdaniil2001@gmail.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #56, base is
docs/decisions-log.compute-plane proposal metadata carries a
Revision (this PR):field holding a whole paragraph about why the preset-field revision was set aside. After merge "this PR" points at nothing, and Overview right below already says the same thing, so it was a third copy of the same rationale with no place of its own.Decision 0001 from #56 is that place now, so the field becomes
Supersedes:plus a link.Andrei Kvapil (@kvaps) it is your proposal, please check I did not drop anything you want kept in the header.