fix(telemetry): make the documented opt-out cover both collectors - #3791
Open
Andrei Kvapil (kvaps) wants to merge 1 commit into
Open
fix(telemetry): make the documented opt-out cover both collectors#3791Andrei Kvapil (kvaps) wants to merge 1 commit into
Andrei Kvapil (kvaps) wants to merge 1 commit into
Conversation
Telemetry is reported by two components, cozystack-operator (cluster facts) and cozystack-controller (application counts), but only the operator had a reachable switch. The documented opt-out sets cozystackOperator.disableTelemetry on the cozy-installer chart, which cannot reach a package the platform deploys, so cozystack-controller kept reporting after an operator had followed the procedure — silently, with nothing to indicate the opt-out was partial. The platform now exposes telemetry.disabled and threads it into the cozystack-controller component of the cozystack-engine Package, the same way the bundle already threads cilium, multus and linstor values. The installer key is also declared in values.yaml: it was only ever referenced from the template, so the documented --set target did not appear in the chart's own values. Both keys stay false by default; this changes no behaviour for anyone who has not opted out. Assisted-By: Claude Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe change adds separate platform and operator telemetry settings. The system bundle propagates platform telemetry opt-out to ChangesTelemetry opt-out
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Andrei Kvapil (kvaps)
marked this pull request as ready for review
August 12, 2026 20:58
Andrei Kvapil (kvaps)
requested review from
IvanHunters,
Aleksei Sviridkin (lexfrei),
Timofei Larkin (lllamnyp) and
myasnikovdaniil
as code owners
August 12, 2026 20:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Telemetry is reported by two components —
cozystack-operator(cluster facts) andcozystack-controller(application counts) — but only the operator had a reachable switch.The documented opt-out sets
cozystackOperator.disableTelemetryon thecozy-installerchart. That chart deploys the operator; it cannot reach a package the platform deploys.packages/system/cozystack-controllerhas its own independentdisableTelemetrykey that nothing propagated to, so after an operator had followed the published procedure the controller kept postingcozy_application_countevery 15 minutes. Nothing failed, and nothing indicated the opt-out was partial.Two changes:
packages/core/platformgains atelemetry.disabledkey and threads it into thecozystack-controllercomponent of thecozystack.cozystack-enginePackage — the same mechanism the bundle already uses for cilium, multus and linstor values.packages/core/installer/values.yamldeclarescozystackOperator.disableTelemetry. It was only ever referenced from the template, so the--settarget the documentation names did not appear in the chart's own values.Both keys default to
false. Nobody who has not opted out sees a behaviour change.The opt-out remains two steps, because the two collectors are installed by two different charts. Collapsing it into one knob would mean the operator writing the value into the platform Package it does not own, which is a design change rather than a fix.
helm unitteston the platform chart: 137 passed (133 before, plus the four added here).helm lintclean on both charts.Screenshots
Not a UI change.
Downstream repositories
Trigger map walked against the diff.
packages/core/platform/values.yamlchanged, which the map routes to the website's hand-written platform-package table; the same change also makes the published opt-out procedure wrong, so the docs follow-up covers both.Release note
Summary by CodeRabbit
New Features
Bug Fixes