Track Cargo.lock to allow deterministic builds - #8
Merged
Conversation
The sentiment around version controlling Cargo.lock seems to differ/evolve a bit. The relevant SO answer quotes a bit dated answer from Rust FAQ [1] that libraries should not version control Cargo.lock. However, the current [2] answer rather makes the sentiment that there are cases, where the lock file is not respected. I would say that this is the burden of the user and actually being explicit about what Cargo.lock was succesfully used to build has its merit. It's, for example, needed also for deterministic builds that I am working on. [1] https://stackoverflow.com/a/63967863 [2] https://doc.rust-lang.org/cargo/faq.html#why-have-cargolock-in-version-control
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sentiment around version controlling Cargo.lock seems to differ/evolve a bit. The relevant SO answer quotes a bit dated answer from Rust FAQ [1] that libraries should not version control Cargo.lock. However, the current [2] answer rather makes the sentiment that there are cases, where the lock file is not respected. I would say that this is the burden of the user and actually being explicit about what Cargo.lock was succesfully used to build has its merit. It's, for example, needed also for deterministic builds that I am working on.
[1] https://stackoverflow.com/a/63967863
[2] https://doc.rust-lang.org/cargo/faq.html#why-have-cargolock-in-version-control