Repository navigation
fix(security): remediate CVE vulnerabilities - #376
Conversation
- Update Go version to 1.26.9 (fixes GO-2026-6612, GO-2026-6604, GO-2026-6603, GO-2026-6611, GO-2026-6608, GO-2026-6607, GO-2026-6609, GO-2026-6613, GO-2026-6605, GO-2026-6610, GO-2026-6617, GO-2026-6599, GO-2026-6600) - Update golang.org/x/net to v0.60.0 (fixes GO-2026-6612, GO-2026-6603, GO-2026-6611, GO-2026-6610, GO-2026-6617) - Update CI workflows to use Go 1.26.9 Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
Build Failure AnalysisCheck: lint SummaryThe lint check failed because golangci-lint v2.4.0 was built with Go 1.25, which is incompatible with the project's Go 1.26.9 requirement. Root CauseThe CVE remediation upgraded Go from 1.25.13 to 1.26.9 in go.mod. However, golangci-lint v2.4.0 in the CI workflow was built with Go 1.25 and cannot operate with Go 1.26.x targets. When golangci-lint tries to load the project configuration, it detects that the target Go version (1.26.9) is higher than its build version (1.25) and refuses to proceed. Error DetailsRecommendationUpgrade golangci-lint in This analysis was generated by the build-failure-analyze skill. |
The previous golangci-lint version (v2.4.0) was built with Go 1.25 and cannot operate with Go 1.26.9 targets. Upgrading to v2.5.0 resolves this compatibility issue. Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
Build Failure AnalysisCheck: lint SummaryThe lint check failed because golangci-lint v2.5.0 is still built with Go 1.25, which is incompatible with the project's Go 1.26.9 requirement. Root CauseThe previous fix upgraded golangci-lint from v2.4.0 to v2.5.0, but v2.5.0 is also built with Go 1.25. golangci-lint cannot operate when its build version is lower than the target Go version. According to golangci-lint documentation, v2.14.0 is the first version built with Go 1.26, providing full support for Go 1.26.x projects. Error DetailsRecommendationUpgrade golangci-lint in This analysis was generated by the build-failure-analyze skill. |
golangci-lint v2.5.0 was still built with Go 1.25. v2.14.0 is the first version built with Go 1.26, providing full support for Go 1.26.x projects. Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
Build Failure AnalysisCheck: lint SummaryGood news: golangci-lint v2.14.0 is now successfully running with Go 1.26.9! However, it's catching 1066 Root Causegolangci-lint v2.14.0 introduced versioned linter names (e.g.,
However, the disable rule for Error DetailsRecommendationUpdate This analysis was generated by the build-failure-analyze skill. |
Build Failure Analysis: lintCheck: lint SummaryThe golangci-lint check failed with 1065 linting errors from linters that should be disabled according to the repository's linting policy. Root CauseThe CI workflow uses golangci-lint v2.14.0, which renamed many linters with version suffixes (e.g., Additionally, the Error DetailsError breakdown:
RecommendationFix required: Update A retry will not help - the configuration file must be updated. |
- Add exhaustruct_v5 to disable list (v2.x versioned name for exhaustruct) - Add modernize to disable list (new linter in v2.x) Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
- Re-enable the modernize linter and disable only its newexpr analyzer, which suggests replacing ptr.To(x) with Go 1.26's new(x) across the codebase. - Fix the one remaining modernize finding (stringsbuilder) by building the joined string with strings.Builder instead of += in a loop. Output is unchanged. - Exclude goconst from test files, consistent with the other linters already excluded there; its v2.14.0 findings were all repeated test fixture strings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
sergenyalcin
left a comment
There was a problem hiding this comment.
Thanks @ulucinar LGTM!
Summary
This PR fixes CVE vulnerabilities identified by security scanning.
Vulnerabilities Fixed
Changes Made
1.25.13to1.26.9ingo.modgolang.org/x/netfromv0.58.0tov0.60.0ingo.modgo mod tidyto update all transitive dependenciesGO_VERSIONto1.26.9in.github/workflows/ci.ymlReferences
Verification