Repository navigation
SDK-369-bwi-issue-with-error-handling - #370
Merged
Merged
Conversation
asafn-ctera
requested review from
saimonation
and
a lite review from Copilot
September 17, 2026 11:14
There was a problem hiding this comment.
🟢 Approval recommended
Reviewed changes have no unresolved blocking issues.
Pull request overview
Updates administrator modification failures to include portal validation messages while preserving generic handling for other errors.
Changes:
- Added HTTP error message formatting.
- Added tests for validation, fallback, and password secrecy.
- Documented SDK-369 in the changelog.
File summaries
| File | Description |
|---|---|
tests/ut/core/admin/test_users.py |
Tests updated failure behavior. |
docs/source/UserGuides/Miscellaneous/Changelog.rst |
Documents SDK-369. |
cterasdk/core/admins.py |
Formats portal messages for HTTP failures. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Yaron-A
marked this pull request as draft
October 11, 2026 14:07
Yaron-A
marked this pull request as ready for review
October 11, 2026 14:07
…sage retrieval, and streamline user-modification exception handling
Yaron-A
force-pushed
the
SDK-369-bwi-issue-with-error-handling
branch
from
October 12, 2026 08:11
ed4c805 to
8880414
Compare
Contributor
|
merge this MR after Yaron synced with Saimon, and aligned the changes according to the code review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Narrow change to exception message formatting on the admin modify failure path; no change to successful modify behavior or API calls.
Overview
Administrators.modifynow surfaces portal validation text when a modify fails with an HTTP transport error that includes a portalmsg(e.g. reusing the current password), instead of only reportingCould not modify user: {ref}.A new
_modify_failure_messagehelper appends thatmsgforHTTPErrorsubclasses; other failures keep the previous generic message. Changelog 2.20.48 documents the fix (SDK-369), and a unit test asserts the raisedCTERAExceptionincludes the portal message without leaking the password value from error fields.Reviewed by Cursor Bugbot for commit e883b88. Configure here.