Repository navigation
kt: SSH clones, run mkdistgitdiff.py with kt's Python, keep remote branch last with -e - #90
Open
hailmo-ciq wants to merge 3 commits into
Open
hailmo-ciq wants to merge 3 commits into
hailmo-ciq wants to merge 3 commits into
Conversation
mkdistgitdiff.py's shebang is #!/usr/bin/python, which may not exist or may lack kt's dependencies. Run it with sys.executable instead.
GHA triggers on branches matching *_<remote branch> (e.g. *_ciqlts9_2).
Appending the -e value at the end ({user}_ciqlts9_2_CVE-...) broke
that, so build the branch as {user}_<extra>_<remote branch> instead.
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the repository access, release-script execution, and branch-naming changes.
No open issues 🎉
What changed in this PR
This PR updates kt repository access, content-release script execution, and checkout branch naming to preserve compatibility with GitHub Actions branch filters.
Changes:
- Clone the kernel source and tools repositories over SSH.
- Run
mkdistgitdiff.pywithkt’s current Python interpreter. - Place checkout
-evalues before the remote branch name, keeping that name as the suffix.
| File | Description |
|---|---|
kt/ktlib/kernel_workspace.py |
Updates source and dist branch naming to keep the remote branch last. |
kt/data/kernels.yaml |
Switches kernel source and tools clone URLs to SSH. |
kt/commands/content_release/impl.py |
Invokes mkdistgitdiff.py using sys.executable. |
kt/commands/checkout/command.py |
Documents the updated branch naming for -e. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some small fix ups based on my onboarding.
kt: clone kernel-src-tree and kernel-src-tree-tools over SSH
kt content-release: run mkdistgitdiff.py with the current interpreter
mkdistgitdiff.py's shebang is #!/usr/bin/python, which may not exist or
may lack kt's dependencies. Run it with sys.executable instead.
kt checkout: put -e extra before the remote branch name
GHA triggers on branches matching *_ (e.g. *ciqlts9_2).
Appending the -e value at the end ({user}ciqlts9_2_CVE-...) broke
that, so build the branch as {user} instead.