Skip to content

[3/3] onboarding favorite sport selector - #119

Open
amjiao wants to merge 7 commits into
onboarding2from
onboarding3
Open

amjiao wants to merge 7 commits into
onboarding2from
onboarding3

Conversation

@amjiao

@amjiao amjiao commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Overview

Implement favorite sport selector screen UI
Implement navigation from profile picture selector to this screen.
Includes logic to remember the selected profile picture

Changes Made

  • some updates to files from [2/3] to use colors from theme/Color.kt

OnboardingFavoriteSportScreen.kt:

  • main UI for this PR

MainActivity.kt:

  • navigation to favorite sport selection to profile picture selection
  • save the selected picture

Test Coverage

visually matches design

Screenshots (delete if not applicable)

Screen_recording_20261021_142511.webm

Summary by CodeRabbit

  • New Features

    • Added a favorite-sports selection step to onboarding.
    • Users can choose sports by gender division and save selections for future use.
    • Added localized labels, completion messages, and selection feedback.
  • UI Improvements

    • Updated onboarding colors, progress indicators, and profile-picture selection styling for a more consistent appearance.

# Conflicts:
#	app/src/main/java/com/cornellappdev/score/MainActivity.kt
@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9eb85ed3-8d49-4dee-9104-c0466d7bd2ce
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@amjiao
amjiao marked this pull request as ready for review October 21, 2026 22:13
@amjiao
amjiao added this pull request to stack #118 October 21, 2026 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant