Repository navigation
docs: print version of a long table — time, job lifetime and size limit (CUB-5736) - #12293
Merged
Merged
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
Contributor
|
Claude finished @mngr's task in 1m 14s —— View job Docs are accurate and ready once enterprise#16599 merges. 0 high, 0 medium, 3 low. Review details
Findings (all low, posted inline)
Checked, no issues
Review threadsThe listing returned 0 of my own threads, so there was nothing to resolve or re-affirm. |
Contributor
|
Claude finished @mngr's task in 45s —— View job LGTM: 0 high, 0 medium, 0 low. Review details
FindingsNone. I checked:
Review threadsThe listing returned 0 of my own unresolved threads, so none were resolved or re-affirmed. No new inline comments were posted. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on cubedevinc/cubejs-enterprise#16599 (and its stacked part cubedevinc/cubejs-enterprise#16598): must not merge before cubedevinc/cubejs-enterprise#16599 merges. The 15-minute print job lifetime and the size-limit failure ship in those two PRs.
Summary
The Print version of a dashboard with a long table (~10,000 rows and more) now downloads instead of timing out. This PR updates the pages that describe it:
docs/explore-analyze/dashboards/index.mdxPreparing PDF…) stays up until the file arrives.reference/control-plane-api.mdx:expiresAtis 5 minutes out, or 15 forlayout: print. A print over the size limit endsfailed, and itserrorasks the caller to narrow the filters.api-reference/api.yaml: mirrors the regenerated public spec's one changed description,POST /api/v1/deployments/{deploymentId}/dashboard-exports. The parsedx-mint.contentequals the new spec'sdescriptionexactly. That is the only path that differs between the merge-base and the head public specs.Verified against the code
exportJobLifetimeMs(printLayout)= 10 min print budget + 5 min TTL for print, 5 min for board (packages/ai-engineer/src/services/dashboard-export-budgets.ts,DashboardScreenshotService.ts:534). console-server keeps the record up toMAX_JOB_TTL_SECONDS= 15 min. On staging-mngr-12 the live POST answeredexpiresAt15.00 min after the press for a print and 5.00 min for a board PDF (cubedevinc/cubejs-enterprise#16599 test plan, AC-7).PRINT_TIMEOUT_MS= 10 min (useExportDashboard.ts:82; a board export keeps 3 min), used for everyprintLayoutrun, the dashboard's and a single table's (useExportDashboard.ts:443). While a print captures, the toast's description reads "Capturing the print version. This can take up to ten minutes." (capturingPrintind3.json,DashboardActions.tsx:101, cubedevinc/cubejs-enterprise@8f51d60755); a board export keeps "Capturing dashboard. This can take up to two minutes." The verify walk recorded the toast sequencePreparing PDF…→Dashboard PDF downloaded. The loading toast stayed up from the press until the file arrived, with 0 danger toasts. Live 10,001-row prints took 31.5–48.6 s.SCREENSHOTER_MAX_PRINT_PDF_BYTES(default 50 MB) with codeprint_too_large. Itserroris "The print version is larger than the export limit. Narrow the dashboard's filters and try again. (job )" (packages/screenshoter/src/routes/screenshot.ts:318). ai-engineer relayserroranderrorCode(DashboardExportController.ts:420-422), and the public status passeserrorthrough (DashboardExportsPublicController.ts:396). The console, the embed Download menu and the widget download each show the translated line "The print version is larger than the export limit. Narrow the dashboard's filters and try again." (verify screenshotverify-4-toast-console-en-us-print-too-large.png). The page names no number, because the limit is a deployment setting.Feature PR: https://github.com/cubedevinc/cubejs-enterprise/pull/16599
Linear: https://linear.app/cube-d3/issue/CUB-5736/dashboard-print-version-download-never-arrives-for-a-table-of-about
Rebased onto master after #12265 (CUB-5561, print a single table) merged into the same page; the merged sections were re-read and still agree with this PR's sentences.