Skip to content

docs: comments on a chart data point - #12305

Merged
igorlukanin merged 4 commits into
masterfrom
igor/cub-5780-docs-point-comments
Oct 23, 2026
Merged

igorlukanin merged 4 commits into
masterfrom
igor/cub-5780-docs-point-comments

Conversation

@igorlukanin

Copy link
Copy Markdown
Member

Summary

  • Adds "Comments on a data point" to the dashboard comments page: starting a thread from a chart's data point, pins with thread counts, the point popover, the point in the comments panel, and what happens when the value changes or the data point leaves the chart.
  • Lists the chart types where comments on a data point are not available.

Test plan

  • Copy matches the UI strings
  • No new links, components or images; one screenshot placeholder in the page's existing TODO style
  • Mintlify preview renders the page

🤖 Generated with Claude Code

@igorlukanin
igorlukanin requested a review from keydunov as a code owner October 16, 2026 23:50
@mintlify

mintlify Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
cubed3 🟢 Ready View Preview Oct 23, 2026, 9:39 PM

💡 Tip: Enable Automations to automatically generate PRs for you.

@github-actions github-actions Bot added the docs Issues that require a documentation improvement label Oct 16, 2026
@claude

claude Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @igorlukanin's task in 58s —— View job


Looks good to merge with small copy fixes: 0 high, 0 medium, 3 low

Review details
  • Read diff
  • Read full page and conventions
  • Check review threads
  • Post review

Findings (all low)

  1. Inconsistent chart type formatting (docs-mintlify/docs/explore-analyze/dashboards/comments.mdx:105). Table, KPI and Map are bold, but Sankey isn't. The chart docs elsewhere write chart types as plain lowercase words. Posted inline with a suggestion.

  2. Intro not updated (docs-mintlify/docs/explore-analyze/dashboards/comments.mdx:7). It still says "Start a thread about the whole dashboard or about one chart", even though the frontmatter description now includes data points. This line isn't in the diff, so the suggestion is here instead of inline:

    Start a thread about the whole dashboard, one chart, or one data point on a chart.

    Fix this →

  3. Unclear pin counts (docs-mintlify/docs/explore-analyze/dashboards/comments.mdx:84-86). "Hover the pin to see the counts" doesn't say which counts. The pin also counts "open" threads, while every other count on the page says "unresolved". Posted inline.

Other notes

  • The {/* TODO: screenshot — … */} placeholder follows docs-mintlify/CLAUDE.md. The section is short and has no new links, so there are no anchors or reference links to check.
  • I couldn't confirm the UI strings (Comment on this point, Start a thread on this point…, Open in comments panel, (as seen on …) / (now)) because the frontend isn't in this repo. The PR's test plan says they were checked.
  • The page doesn't say whether data-point threads are included in the chart's Add comment count and in the chart filter in the panel picker. Consider adding one sentence if they are.
  • I didn't build a Mintlify preview. That item in the test plan is still open.

Review threads

The listing returned 0 of my threads (no prior threads), so I resolved none and re-affirmed none.

Comment thread docs-mintlify/docs/explore-analyze/dashboards/comments.mdx Outdated
Comment thread docs-mintlify/docs/explore-analyze/dashboards/comments.mdx Outdated
@claude

claude Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @igorlukanin's task in 1m 3s —— View job


Copy is accurate and in the page's style. 0 high, 0 medium, 3 low.

Review details

Findings

  1. Low: the intro at docs-mintlify/docs/explore-analyze/dashboards/comments.mdx:7 still says "Start a thread about the whole dashboard or about one chart." The frontmatter description now mentions data points, but the body intro was not updated. Not posted inline because line 7 is outside the diff. Suggested wording: "…about the whole dashboard, one chart, or one data point on a chart." Fix this →
  2. Low: comments.mdx:86 is about 110 characters wide; the rest of the page wraps at about 80. Posted inline with a rewrap.
  3. Low: at comments.mdx:107, "On these charts, comment on the whole chart instead" comes after the Boxplot sentence, so it reads as if it includes Boxplot, which does allow comments on outliers. Posted inline with a reorder.

Not verified

The UI strings (Comment on this point, Open in comments panel, Start a thread on this point…, the "(as seen on …)" / "(now)" format) live in the closed-source app, not in this repo, so I could not check them against the code. The PR's test plan says the author checked them.

Should Live updates (line 157) also say that pins update live? Only add it if the app actually does that.

Review threads

The listing returned 0 of my own threads: none to resolve, none to re-affirm.

Checklist

  • Read the diff and the full page
  • Check the copy against the page's conventions and the rest of the docs
  • Resolve stale review threads
  • Post the review

Comment thread docs-mintlify/docs/explore-analyze/dashboards/comments.mdx Outdated
Comment thread docs-mintlify/docs/explore-analyze/dashboards/comments.mdx Outdated
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@igorlukanin
igorlukanin force-pushed the igor/cub-5780-docs-point-comments branch from 704f3d1 to 0b40311 Compare October 23, 2026 15:37
@igorlukanin

Copy link
Copy Markdown
Member Author

Fixed the intro in 0b40311: it now says a thread can be about a data point too. Also rebased on master, which picked up the reply-notifications change on the same page.

@claude

claude Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @igorlukanin's task in 1m 10s —— View job


Looks good, with minor nits: 0 high, 0 medium, 2 low (1 new, 1 still open from an earlier round)

Review details
  • Read diff and changed file
  • Review copy
  • Review threads
  • Post review

Findings

  • Low (new): docs-mintlify/docs/explore-analyze/dashboards/comments.mdx:101 uses "grey". The rest of the docs use US spelling ("gray", "color"). I left an inline suggestion.
  • Low (still open): docs-mintlify/docs/explore-analyze/dashboards/comments.mdx:110: "On these charts, comment on the whole chart instead" comes right after the Boxplot sentence, so it reads as if it covers Boxplot too, where outlier points can be commented on. The existing thread already covers this, so I didn't post it again.

Notes

  • The new section fits the page: it follows the same pattern as "Comments on a chart", the UI strings are bold, and the screenshot placeholder uses the {/* TODO: screenshot — … */} format from docs-mintlify/CLAUDE.md.
  • This is a docs-only PR, so there are no code, security, performance or test concerns.
  • I couldn't check the list of unsupported chart types (Table, KPI, HTML, Map, Sankey, Funnel, and Boxplot outliers only) because the app UI code is not in this repo.

Review threads

The listing returned 2 of my own unresolved threads:

  • Resolved 1 (PRRT_kwDOCOH19M6vqsxV): the line-wrap issue at line 86 is fixed.
  • Re-affirmed 1 (PRRT_kwDOCOH19M6vqs03): the Boxplot / "these charts" wording at line 110 still applies.

Comment thread docs-mintlify/docs/explore-analyze/dashboards/comments.mdx Outdated
@claude

claude Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @igorlukanin's task in 39s —— View job


Looks good to merge: 0 high, 0 medium, 0 low. Both earlier nits are fixed.

Review details
  • Read diff and changed file
  • Review copy
  • Review threads
  • Post review

Findings

None.

Notes

  • Both earlier findings are fixed. docs-mintlify/docs/explore-analyze/dashboards/comments.mdx:101 now says "gray". In comments.mdx:107-109, "comment on the whole chart instead" now comes before the Boxplot sentence, so it no longer reads as covering Boxplot.
  • The intro and the frontmatter description now mention data points too, so they match the new section.
  • This is a docs-only PR, so there are no code, security, performance or test concerns.
  • I couldn't check the list of unsupported chart types (Table, KPI, HTML, Map, Sankey, Funnel, and Boxplot outliers only) because the app UI code is not in this repo.

Review threads

No prior threads: the listing returned 0 of my own unresolved threads, so I resolved none and re-affirmed none.

@igorlukanin
igorlukanin merged commit 93dbe66 into master Oct 23, 2026
20 checks passed
@igorlukanin
igorlukanin deleted the igor/cub-5780-docs-point-comments branch October 23, 2026 21:43

This branch was successfully deployed

1 active deployment
staging - docs-mintlify — f7841752 Deployed Oct 23, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Issues that require a documentation improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant