Repository navigation
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
|
Claude finished @mngr's task in 1m 10s —— View job Looks good to merge once cubedevinc/cubejs-enterprise#16918 lands: 0 high, 0 medium, 3 low (wording only). Review details
Findings (all low, posted inline)
What I checked
Review threadsThe listing returned 0 of my own threads, so there was nothing to resolve or re-affirm. All 3 findings were posted as new inline comments. |
|
Claude finished @mngr's task in 52s —— View job No issues found: 0 high, 0 medium, 0 low. Review details
FindingsNone. I checked the whole page and the rest of
I left no inline comments, since nothing of medium or high severity came up and the earlier low-severity notes were already accepted as written. Review threadsThe listing returned no unresolved threads of mine, so I resolved 0 and re-affirmed 0. The three threads from the last round have already been resolved. |
|
Claude finished @mngr's task in 45s —— View job No issues found (0 high, 0 medium, 0 low posted) Review details
ResultI found no medium or high issues in What I checked:
I left out low-severity editorial points, as the author asked on the earlier threads. One of them: around line 241, the hand-made Create case says the page opens "beside a new, empty chat", but there is no chat if the user can't use Analytics Chat. The sentence before it already sets that condition, so I'm not raising it. No public API or behaviour changes are left undocumented. This is a docs-only PR, and the Review threadsThe listing returned 0 of my own unresolved threads (no prior threads), so I resolved 0 and re-affirmed 0. |
Depends on cubedevinc/cubejs-enterprise#16918. Do not merge before it. Based on
master, squashed and rebased on top of the merged #12266 (CUB-5670, recipients and channels) and #12306 (CUB-5218). Those PRs' text on this page is the base; this PR only moves their "task dialog" wording onto the task page's Settings.Summary
The task dialog is gone. A scheduled task is now edited on its own page, which has three parts: run history on the left, the task's Settings in the middle, and the agent chat on the right. The agent changes the task while it is on screen. Changes to
docs/explore-analyze/scheduled-tasks.mdx:share.viewOnly), not "Shared with you". Its settings have no Update and none of them can be edited.The public API's chat-history
initialContextenum gainsscheduled-task.api-reference/api.yamlandchangelog.mdxare synced from platform-client releases, so that value arrives with the next sync and is not edited by hand here.What I verified against the code
Checked against the feature branch at
f7abf73b13and the newest hand-off walk on staging-mngr-11 (handoff-walk-r3.log, deployment 2015):ScheduledTasksPage.tsxkeeps master'sonRowClickand adds no name-cell control. Walk step 10: with the pointer on the row,ScheduledTaskOpen*matches 0 elements on the page. The ⋮ menu reads Run now / Check now / Delete, with no Edit, and a click on the name opens/scheduled-tasks/<id>.Button to=".../scheduled-tasks/new". Walk step 1: no menu opens, Name and Instructions are empty, and the set-up message is posted with no typing.ScheduledTaskSideChatsendspage.createWithAgentPromptonly whenhasAccess('scheduled-task')is true and no chat is open, hence "if you can use Analytics Chat".openCreatedTask(id, false). That dropschatIdand does not reopen the set-up chat. Walk step 2: "Scheduled task created" shows, the URL is/scheduled-tasks/9066withchatIdnull, the transcript has 0 messages, and the chat's History control lists the set-up chat.ScheduledTaskPageChatContext.onTaskCreated, which isopenCreatedTask(id, true)and keeps the chat.ScheduledTaskActionsrenders Share (only whencanManage), Delete, Check now (conditional task) and Run now.isCompactmakes them icon-only, named byaria-labeland tooltip.ScheduledTaskChatToggleis always an icon, labelled Show chat / Hide chat.ScheduledTaskDetailPage.tsx): the history column shows the description and the status tag, thenScheduledTaskActivity, which rendersScheduledTaskConditionbeforeScheduledTaskRunHistory. On@mobilethe grid is one column.ScheduledTaskSettings.tsx):changedFieldssends only the changed settings. Update is disabled when nothing has changed, the condition has a problem, or a condition notifies nobody; its tooltip in that last case isconditionNeedsNotification. Name and instructions arerequired.ScheduledTaskNotifyFieldsis part of the panel, with the Slack connect prompt,notifyNoChannelHintandnotifyRecipientNotShared.canManage === false): the form isisDisabledwith no Submit, and the header shows theScheduledTaskViewOnlytag in place of the actions.AttachmentPreview.tsx): walk step 4 reads the whole 59-character name in the chip, cut by width, and whole in the hover tooltip. Walk step 8 drags the chat to its 300 px minimum: the chip is 28×28 with 0 px of the name painted, and hovering the icon shows the whole name.0 8 * * *, there is still one task, and the write isupdateScheduledTask. Walk step 6 adds a condition from chat the same way.agentIdis onUpdateScheduledTaskToolFactoryand on create (omitted means the chat's agent, null means the deployment default).ScheduledTaskSidebarDetailpasseseditHref= the task page plus?chatId=<current chat>.Feature PR: cubedevinc/cubejs-enterprise#16918 (https://github.com/cubedevinc/cubejs-enterprise/pull/16918)
Linear: https://linear.app/cube-d3/issue/CUB-5599/make-scheduled-tasks-editable-via-ai-chat