Skip to content

docs: edit a scheduled task on its page beside the agent chat (CUB-5599) - #12362

Open
mngr wants to merge 1 commit into
masterfrom
docs/cub-5599
Open

mngr wants to merge 1 commit into
masterfrom
docs/cub-5599

Conversation

@mngr

@mngr mngr commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

Depends on cubedevinc/cubejs-enterprise#16918. Do not merge before it. Based on master, squashed and rebased on top of the merged #12266 (CUB-5670, recipients and channels) and #12306 (CUB-5218). Those PRs' text on this page is the base; this PR only moves their "task dialog" wording onto the task page's Settings.

Summary

The task dialog is gone. A scheduled task is now edited on its own page, which has three parts: run history on the left, the task's Settings in the middle, and the agent chat on the right. The agent changes the task while it is on screen. Changes to docs/explore-analyze/scheduled-tasks.mdx:

  • List: a click on a row opens the task's page, and rows show no button on hover. New task is now a single button instead of the Create with agent / Set up manually dropdown. It opens a New scheduled task page and posts the set-up message to the chat for you. If the agent creates the task, its chat stays open on the new task's page. If you press Create by hand, the task's page opens beside a new, empty chat, and the set-up conversation stays in the chat's history. Edit is gone from the row actions, and the toggle no longer disables an Edit while it saves.
  • Task detail page:
    • The header has Share, Delete, Check now and Run now, and no pencil. On a narrow window the labelled buttons show only their icons. On a conditional task, hovering Run now says it runs the agent without checking the condition.
    • The page describes the three-part layout; on a narrow window the history sits above the settings.
    • The left column shows the description and the status tag, then Condition (on a conditional task) above History. The Instructions, Repeats and Notifies blocks are gone, because the Settings panel shows all three.
    • Two new subsections: Changing a task's settings (Update is enabled only after a change and saves only the changed settings; name and instructions are required; an incomplete condition keeps Update disabled) and Changing a task with the agent (the task chip beside the agent picker, the in-place change, unsaved edits kept, and Hide chat / Show chat).
  • "Task dialog" wording moved to the task's Settings, in the Conditional tasks section and in Notifying people when a run finishes:
    • Create/Update stays disabled until a conditional task notifies someone.
    • The panel offers to connect Slack and says when nobody is notified.
    • It marks a recipient Not shared: won't be notified.
    • Channels belong to the whole task.
  • Managing tasks from chat: the agent can report a task's agent and pick one, or set it back to Deployment default. The pencil in the chat's side panel opens the task's page with that chat beside it. The Create with agent reference is removed; master's data-alerts sentence is kept.
  • A sentence already wrong on master, corrected: a view-only task's tag reads View only (share.viewOnly), not "Shared with you". Its settings have no Update and none of them can be edited.

The public API's chat-history initialContext enum gains scheduled-task. api-reference/api.yaml and changelog.mdx are synced from platform-client releases, so that value arrives with the next sync and is not edited by hand here.

What I verified against the code

Checked against the feature branch at f7abf73b13 and the newest hand-off walk on staging-mngr-11 (handoff-walk-r3.log, deployment 2015):

  • List: ScheduledTasksPage.tsx keeps master's onRowClick and adds no name-cell control. Walk step 10: with the pointer on the row, ScheduledTaskOpen* matches 0 elements on the page. The ⋮ menu reads Run now / Check now / Delete, with no Edit, and a click on the name opens /scheduled-tasks/<id>.
  • New task: it is a Button to=".../scheduled-tasks/new". Walk step 1: no menu opens, Name and Instructions are empty, and the set-up message is posted with no typing. ScheduledTaskSideChat sends page.createWithAgentPrompt only when hasAccess('scheduled-task') is true and no chat is open, hence "if you can use Analytics Chat".
    • A hand-made Create calls openCreatedTask(id, false). That drops chatId and does not reopen the set-up chat. Walk step 2: "Scheduled task created" shows, the URL is /scheduled-tasks/9066 with chatId null, the transcript has 0 messages, and the chat's History control lists the set-up chat.
    • An agent create goes through ScheduledTaskPageChatContext.onTaskCreated, which is openCreatedTask(id, true) and keeps the chat.
  • Header: ScheduledTaskActions renders Share (only when canManage), Delete, Check now (conditional task) and Run now. isCompact makes them icon-only, named by aria-label and tooltip. ScheduledTaskChatToggle is always an icon, labelled Show chat / Hide chat.
    • Walk step 9 at 800 px and 390 px: all five are 32×32 icons inside the viewport, and Run now's tooltip reads "Runs the agent now without checking the condition.".
    • A press at the chat button's centre opens the chat.
  • Layout (ScheduledTaskDetailPage.tsx): the history column shows the description and the status tag, then ScheduledTaskActivity, which renders ScheduledTaskCondition before ScheduledTaskRunHistory. On @mobile the grid is one column.
    • Walk step 2 at 1600 px: history | settings | chat side by side.
    • Walk step 6: the condition block's bottom (369) sits above the run history's top (393).
    • Walk step 9: the history column sits above the settings at 800 and 390 px.
  • Settings (ScheduledTaskSettings.tsx): changedFields sends only the changed settings. Update is disabled when nothing has changed, the condition has a problem, or a condition notifies nobody; its tooltip in that last case is conditionNeedsNotification. Name and instructions are required.
    • ScheduledTaskNotifyFields is part of the panel, with the Slack connect prompt, notifyNoChannelHint and notifyRecipientNotShared.
    • A new task's notification is the current user plus Inbox when the inbox is on.
    • View-only (canManage === false): the form is isDisabled with no Submit, and the header shows the ScheduledTaskViewOnly tag in place of the actions.
    • Walk step 3: "Scheduled task updated" shows, and Update is disabled again.
  • Chip (AttachmentPreview.tsx): walk step 4 reads the whole 59-character name in the chip, cut by width, and whole in the hover tooltip. Walk step 8 drags the chat to its 300 px minimum: the chip is 28×28 with 0 px of the name painted, and hovering the icon shows the whole name.
  • Agent edit: walk step 5 sends "Run it every day at 8:00 instead.". The panel reads "Every day at 8:00 AM" with no reload, the cron is 0 8 * * *, there is still one task, and the write is updateScheduledTask. Walk step 6 adds a condition from chat the same way.
  • Agent picking: agentId is on UpdateScheduledTaskToolFactory and on create (omitted means the chat's agent, null means the deployment default).
  • Sidebar pencil: ScheduledTaskSidebarDetail passes editHref = the task page plus ?chatId=<current chat>.

Feature PR: cubedevinc/cubejs-enterprise#16918 (https://github.com/cubedevinc/cubejs-enterprise/pull/16918)
Linear: https://linear.app/cube-d3/issue/CUB-5599/make-scheduled-tasks-editable-via-ai-chat

@mngr
mngr requested a review from keydunov as a code owner October 22, 2026 08:38
@mintlify

mintlify Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
cubed3 🟢 Ready View Preview Oct 24, 2026, 3:00 AM

💡 Tip: Enable Automations to automatically generate PRs for you.

@github-actions github-actions Bot added docs Issues that require a documentation improvement pr:community Contribution from Cube.js community members. labels Oct 22, 2026
@claude

claude Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @mngr's task in 1m 10s —— View job


Looks good to merge once cubedevinc/cubejs-enterprise#16918 lands: 0 high, 0 medium, 3 low (wording only).

Review details
  • Read diff
  • Read full page for consistency, grep docs for stale references
  • Resolve stale threads / dedupe
  • Post review

Findings (all low, posted inline)

  1. docs-mintlify/docs/explore-analyze/scheduled-tasks.mdx:199-201: the view-only sentence is ambiguous. It can be read as the View only tag replacing the settings, and "none of them editable" has no clear referent. I suggested splitting it into two sentences.
  2. scheduled-tasks.mdx:255-258: the header action list leaves out Hide chat / Show chat, while :318 says both are "in the header". Separately, "hover one to see its name" leaves out keyboard focus, which the row Open button wording at :29 does mention.
  3. scheduled-tasks.mdx:381-383: it's unclear what "its pencil button" refers to. I suggested naming the side panel.

What I checked

  • No other page under docs-mintlify/ still refers to Create with agent, Set up manually, "task dialog", or "Shared with you" for tasks. The inbound anchors (#getting-notified-when-a-run-finishes, #conditional-tasks, #task-detail-page) all still resolve.
  • The notification default fits with the rest of the page. It's on for a task made with Create (:346) and off for one the agent makes (:354), so a task the agent creates on the New scheduled task page starts with notifications off.
  • The note that Update saves only the changed settings and doesn't undo changes the agent made elsewhere (:313-316) fits the changedFields behaviour described in the PR body.
  • I couldn't check against the UI source: cubejs-enterprise isn't in this checkout. Statements about UI behaviour are checked only against the PR description.
  • It's a docs-only change, so no tests or build apply.

Review threads

The listing returned 0 of my own threads, so there was nothing to resolve or re-affirm. All 3 findings were posted as new inline comments.

Comment thread docs-mintlify/docs/explore-analyze/scheduled-tasks.mdx
Comment thread docs-mintlify/docs/explore-analyze/scheduled-tasks.mdx
Comment thread docs-mintlify/docs/explore-analyze/scheduled-tasks.mdx Outdated
@claude

claude Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @mngr's task in 52s —— View job


No issues found: 0 high, 0 medium, 0 low.

Review details
  • Read diff
  • Check the full page for leftover dialog references and consistency
  • Review threads
  • Post review

Findings

None. I checked the whole page and the rest of docs-mintlify:

  • Dialog wording: no "task dialog", Create with agent, Set up manually, row Edit or Shared with you remains anywhere in docs-mintlify. The only places that still say "edit" mean changing a task, which still applies (scheduled-tasks.mdx:162, :211, :215, :357).
  • Links: the #task-detail-page anchor is kept, so links from other pages and the open PRs on this page still work. The new sections (### Changing a task's settings, ### Changing a task with the agent) sit under it as subsections. The links to #anatomy-of-a-task, #conditional-tasks and #limits still go to existing headings.
  • Create permission: the note that users without Create scheduled tasks get no New task button still holds now that the dropdown is a single button.
  • Header and layout: they match the walk-through in the PR description. Delete is already icon-only, so leaving it out of the narrow-window icon list is correct.

I left no inline comments, since nothing of medium or high severity came up and the earlier low-severity notes were already accepted as written.

Review threads

The listing returned no unresolved threads of mine, so I resolved 0 and re-affirmed 0. The three threads from the last round have already been resolved.

@claude

claude Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @mngr's task in 45s —— View job


No issues found (0 high, 0 medium, 0 low posted)

Review details
  • Read the diff and the changed file
  • Check accuracy and consistency
  • Check review threads
  • Post the review

Result

I found no medium or high issues in docs-mintlify/docs/explore-analyze/scheduled-tasks.mdx at this commit, so I posted no inline comments.

What I checked:

  • Old wording: the page no longer mentions the task dialog, the Create with agent / Set up manually dropdown, the Edit row action, the header pencil or Shared with you. The only "dialog" left is the Share dialog, which still exists. The only pencil left is the one in the chat's side panel, which the PR adds on purpose.
  • Links: the anchors other pages use (#notifying-people-when-a-run-finishes and #conditional-tasks, both used in docs/inbox.mdx) still exist. No other page under docs-mintlify/ describes the old dialog or dropdown.
  • Consistency: the new subsections agree with the rest of the page:
    • The header actions match the view-only text at line 208 (a View only tag in place of the actions, and no Update).
    • The Condition block now sits above History, as described.
    • The agent-picking text matches the Anatomy change ("unless you ask the agent for another").

I left out low-severity editorial points, as the author asked on the earlier threads. One of them: around line 241, the hand-made Create case says the page opens "beside a new, empty chat", but there is no chat if the user can't use Analytics Chat. The sentence before it already sets that condition, so I'm not raising it.

No public API or behaviour changes are left undocumented. This is a docs-only PR, and the initialContext enum change arrives with the platform-client sync, as the description says.

Review threads

The listing returned 0 of my own unresolved threads (no prior threads), so I resolved 0 and re-affirmed 0.

This branch was successfully deployed

1 active deployment
staging - docs-mintlify — fb0fd887 Deployed Oct 24, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Issues that require a documentation improvement pr:community Contribution from Cube.js community members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant