Audio: adjust import and export annotations dialogs for 1D - #11081
Audio: adjust import and export annotations dialogs for 1D#11081lexiv0re wants to merge 5 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
@klakhov please review |
|
Bulk export can still send “Save images” for 1D tasks. The visibility check at export-dataset-modal.tsx (line 340) only evaluates the task whose action menu was opened. In a mixed 2D/1D bulk selection opened from a 2D task, the switch remains available and its value is passed to every selected instance, including 1D tasks. I guess we should ignore this option for 1d tasks. Also it would make sense to add UI coverage for 1D import and export dialogs: verify that “Convert masks to polygons” and “Save images” are absent |
|
Hmm, it means there will also be a problem if mixed bulk export is opened from 1D - "Save images" will be absent and won't be configurable for 2D from this bulk selection - the default will always be used. |
|
Export dialog for bulk export now only shows |
|
@klakhov please review again |
Motivation and context
Import and export annotation dialogs contain configurations non-relevant for audio (1D). Sometimes they may also lead a failed operation. E.g. trying to export audio annotations with
Save imagesoption enabled leads to an error.This change removes
Save imagesoption from the export dialog andConvert masks to polygonsoption from the import dialog for 1D jobs/tasks/projects.Import
Before:

After:

Export
Before:

After:

How has this been tested?
Tested manually
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.