Skip to content

Audio: adjust import and export annotations dialogs for 1D - #11081

Open
lexiv0re wants to merge 5 commits into
developfrom
asz/1d-import-export-opts
Open

Audio: adjust import and export annotations dialogs for 1D#11081
lexiv0re wants to merge 5 commits into
developfrom
asz/1d-import-export-opts

Conversation

@lexiv0re

@lexiv0re lexiv0re commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Motivation and context

Import and export annotation dialogs contain configurations non-relevant for audio (1D). Sometimes they may also lead a failed operation. E.g. trying to export audio annotations with Save images option enabled leads to an error.

This change removes Save images option from the export dialog and Convert masks to polygons option from the import dialog for 1D jobs/tasks/projects.

Import

Before:
ImportOld

After:
ImportNew

Export

Before:
ExportOld

After:
ExportNew

How has this been tested?

Tested manually

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@lexiv0re
lexiv0re requested a review from bsekachev as a code owner August 26, 2026 07:48
@lexiv0re
lexiv0re requested a review from nmanovic as a code owner August 26, 2026 08:04
@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@bsekachev
bsekachev requested a review from klakhov August 26, 2026 09:42
@bsekachev

Copy link
Copy Markdown
Member

@klakhov please review

@klakhov

klakhov commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Bulk export can still send “Save images” for 1D tasks. The visibility check at export-dataset-modal.tsx (line 340) only evaluates the task whose action menu was opened. In a mixed 2D/1D bulk selection opened from a 2D task, the switch remains available and its value is passed to every selected instance, including 1D tasks. I guess we should ignore this option for 1d tasks.

Also it would make sense to add UI coverage for 1D import and export dialogs: verify that “Convert masks to polygons” and “Save images” are absent

@lexiv0re

Copy link
Copy Markdown
Contributor Author

Hmm, it means there will also be a problem if mixed bulk export is opened from 1D - "Save images" will be absent and won't be configurable for 2D from this bulk selection - the default will always be used.

@lexiv0re

Copy link
Copy Markdown
Contributor Author

Export dialog for bulk export now only shows Save images option if there's at least one non-audio item in the selection. For all audio items it's effectively set to false regardless of the selection.
Moreover, since different dimension items don't have any shared export formats now, the bulk export option is disabled in the context menu for such selection.
Also, adjusted/added e2e tests for audio import/export.

@lexiv0re

Copy link
Copy Markdown
Contributor Author

@klakhov please review again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants