Skip to content

SRE-3892 cq: install dependencies while building docker image - #18684

Open
grom72 wants to merge 4 commits into
masterfrom
grom72/sre3892-install-deps
Open

SRE-3892 cq: install dependencies while building docker image#18684
grom72 wants to merge 4 commits into
masterfrom
grom72/sre3892-install-deps

Conversation

@grom72

@grom72 grom72 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Optimize Docker-based DAOS dependency installation with RUN --mount and simplified build variables

Description

This PR refactors the DAOS build infrastructure to move dependency installation into Docker layer phases, improving build efficiency and simplifying the variable management chain.

Problem

Dependency installation (install_deps.sh) was executed outside Docker in the CI pipeline, requiring manual invocation and repeats the same procedure in every docker container
Unused environment variables (DAOS_RELVAL, REPO_SPEC, CHROOT_NAME) cluttered the build pipeline

Solution

Move dependency installation into Docker:
Consolidate version definitions: Move daos_version and daos_release directly into daos.sh (their only consumer), eliminating unnecessary intermediate dependencies
Simplify variable management: Remove unused variables and their definitions

Requires:

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@github-actions

Copy link
Copy Markdown

Errors are Unable to load ticket data
https://daosio.atlassian.net/browse/SRE-3892

@grom72
grom72 force-pushed the grom72/sre3892-install-deps branch 7 times, most recently from 29d71c4 to 72d825d Compare July 22, 2026 17:01
grom72 added 2 commits July 22, 2026 20:32
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

Priority: 2
Cancel-prev-build: false
Skip-python-bandit: true
Skip-build-el8-gcc: true
Skip-build-leap15-gcc: true
Skip-unit-test: true
Skip-unit-test-memcheck: true
Skip-test-el-9-rpms: true
Skip-test-leap-15-rpms: true
Skip-func-vm-test: true
Skip-func-hw-test: true
Skip-build-el8-gcc: true
Skip-build-leap15-gcc: true
Skip-unit-tests:true
Skip-NLT: true
Skip-fault-injection-test: true
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

Priority: 2
Cancel-prev-build: false
Skip-python-bandit: true
Skip-build-el8-gcc: true
Skip-build-leap15-gcc: true
Skip-unit-test: true
Skip-unit-test-memcheck: true
Skip-test-el-9-rpms: true
Skip-test-leap-15-rpms: true
Skip-func-vm-test: true
Skip-func-hw-test: true
Skip-build-el8-gcc: true
Skip-build-leap15-gcc: true
Skip-unit-tests:true
Skip-NLT: true
Skip-fault-injection-test: true
@grom72
grom72 force-pushed the grom72/sre3892-install-deps branch from 72d825d to 6eb8bc6 Compare July 22, 2026 18:41
@daosbuild3

Copy link
Copy Markdown
Collaborator

@grom72
grom72 force-pushed the grom72/sre3892-install-deps branch from 6eb8bc6 to bc77452 Compare July 22, 2026 18:50
DAOS_RELVAL is needed only for DAOS build.
STAGE_NAME is not needed for dependency installation.
REPO_SPEC is no longer needed.

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

Priority: 2
Cancel-Previous-Builds: false
Skip-func-hardware-test: true
Skip-func-hw-test: true
@grom72
grom72 force-pushed the grom72/sre3892-install-deps branch from bc77452 to 9154a77 Compare July 22, 2026 21:25
@grom72
grom72 marked this pull request as ready for review July 22, 2026 21:25
@grom72
grom72 requested a review from a team as a code owner July 22, 2026 21:25
@daosbuild3

Copy link
Copy Markdown
Collaborator

…all-deps

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

Skip-func-hardware-test: true
Skip-func-hw-test: true
@grom72
grom72 force-pushed the grom72/sre3892-install-deps branch from af6aecb to a788c4c Compare July 23, 2026 08:47
Comment thread utils/rpms/daos.sh
@grom72
grom72 requested a review from phender July 24, 2026 05:49
@daltonbohning
daltonbohning requested a review from jolivier23 July 31, 2026 16:11
@grom72
grom72 requested review from a team and removed request for JohnMalmberg, janekmi, jolivier23 and ryon-jensen August 17, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants