Skip to content

Type checking part of lint, and group build/validate statuses - #1178

Merged
acroca merged 1 commit into
dapr:mainfrom
acroca:improve-ci
Aug 4, 2026
Merged

Type checking part of lint, and group build/validate statuses#1178
acroca merged 1 commit into
dapr:mainfrom
acroca:improve-ci

Conversation

@acroca

@acroca acroca commented Jul 27, 2026

Copy link
Copy Markdown
Member
  • Run uv run mypy as part of the lint process because it doesn't require run in a matrix.
  • Add a completion CI step so we can mark is as required and it'll group all checks into one requirement.

Signed-off-by: Albert Callarisa <albert@diagrid.io>
@acroca
acroca requested review from a team as code owners July 27, 2026 15:27
@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.77%. Comparing base (d612c9e) to head (d291688).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1178      +/-   ##
==========================================
- Coverage   82.84%   82.77%   -0.07%     
==========================================
  Files         123      123              
  Lines       10130    10130              
==========================================
- Hits         8392     8385       -7     
- Misses       1738     1745       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@acroca
acroca added this pull request to the merge queue Jul 27, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jul 27, 2026
@yaron2
yaron2 added this pull request to the merge queue Aug 1, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Aug 1, 2026
@acroca

acroca commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

This wasn't merged and it's blocking other PRs. Maybe we need to disable the checks in the repo settings so this can be merged and then add them back?

@acroca
acroca added this pull request to the merge queue Aug 4, 2026
Merged via the queue into dapr:main with commit f33c29f Aug 4, 2026
20 of 21 checks passed
@acroca
acroca deleted the improve-ci branch August 4, 2026 10:06
@acroca

acroca commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

I had to disable DCO from the required checks, it doesn't seem to trigger the check in the merge queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants