Skip to content

chore(deps): bump Go to 1.26.6 - #1417

Merged
lklimek merged 1 commit into
v1.7-devfrom
chore/bump-go-1.26.6
Aug 26, 2026
Merged

chore(deps): bump Go to 1.26.6#1417
lklimek merged 1 commit into
v1.7-devfrom
chore/bump-go-1.26.6

Conversation

@lklimek

@lklimek lklimek commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

TL;DR: Bumps the pinned Go toolchain from 1.26.5 to 1.26.6 across the repo (go.mod, CI workflows, Dockerfiles, docs) to clear six pre-existing Go standard-library vulnerability findings that govulncheck currently reports on v1.7-dev and on every open dependency-bump PR.

Detailed discussion

This is a pure internal/CI change with no user-observable behavior — no User story / Scenario sections.

Issue being fixed or feature implemented

govulncheck fails identically on v1.7-dev and on every open PR branch (#1412, #1411, #1410), independent of what each PR actually changes:

Fixed in: net/url@go1.26.6
Fixed in: html/template@go1.26.6
Fixed in: crypto/tls@go1.26.6
Fixed in: net/http@go1.26.6 (x2)
Fixed in: encoding/asn1@go1.26.6

All six are Go standard-library vulnerabilities (GO-2026-6218, 6091, 6090, 6089 x2, 5972), found at go1.26.5 and fixed at go1.26.6. None live in any third-party module, so no dependency bump can fix them. They're reachable from our TLS/RPC/HTTP server and Dash Core client paths — the same call sites documented in #1395, which fixed the previous instance of this exact pattern (1.26.4 → 1.26.5).

Confirmed via three independent dependency-review passes this session that the same six IDs, in the same order, are already present on a plain v1.7-dev push with no dependabot involvement — this is blocking unrelated PRs, not something any of them introduced.

What was done?

Bumped Go from 1.26.5 to 1.26.6 at every pin, mirroring #1395's file list exactly:

  • go.mod
  • DOCKER/Dockerfile, test/docker/Dockerfile, test/e2e/docker/Dockerfile
  • go-version in the build, check-generated, e2e, govulncheck, lint, release and tests workflows, and .github/actions/bls/action.yml
  • README.md, docs/tutorials/go.md, docs/tutorials/go-built-in.md, test/fuzz/README.md

Patch release only — no language or API changes.

How Has This Been Tested?

Locally, with the Go 1.26.6 toolchain:

go build ./...            # succeeds
govulncheck ./...          # 0 vulnerabilities (down from 6)

CI on this PR exercises the full build, lint, unit and e2e suites on the new toolchain — that's the authoritative signal for anything this local run couldn't reach.

Breaking Changes

None. Go patch release; no language or standard library API changes.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Prior work

Attribution

🤖 Co-authored by Claudius the Magnificent AI Agent

govulncheck fails identically on v1.7-dev and every open PR branch
(#1412, #1411, #1410) with 6 Go standard-library findings, all
"Found in: go1.26.5 / Fixed in: go1.26.6":

- GO-2026-6218 (net/url)
- GO-2026-6091 (html/template)
- GO-2026-6090 (crypto/tls)
- GO-2026-6089 (net/http, x2)
- GO-2026-5972 (encoding/asn1)

Reachable from our TLS/RPC/HTTP server and Dash Core client paths
(same call sites as PR #1395). Bumping the pinned toolchain from
1.26.5 to 1.26.6 turns govulncheck green everywhere at once and
unblocks #1412, #1411, #1410.

Mirrors PR #1395's pattern (1.26.4 -> 1.26.5): pure patch-release
toolchain swap, no language/API changes, same 16 files touched
(go.mod, CI workflow go-version pins, Dockerfiles, docs).

Verified locally with go1.26.6: go build ./... succeeds, and
govulncheck ./... reports 0 vulnerabilities (down from 6).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RoXmbFrVf1BqVW1BHZv6Va
@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: abd1f586-38dc-4da1-adcc-2687c9076192

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lklimek
lklimek marked this pull request as ready for review August 25, 2026 10:07
@lklimek
lklimek enabled auto-merge (squash) August 25, 2026 10:07
@thepastaclaw

thepastaclaw commented Aug 25, 2026

Copy link
Copy Markdown

✅ Final review complete — no blockers (commit 66fc928)

@lklimek
lklimek disabled auto-merge August 25, 2026 10:34
@lklimek
lklimek enabled auto-merge (squash) August 25, 2026 10:34

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final validation — Codex/Sol only (Phase 2 disabled)

The Go 1.26.6 toolchain bump is applied consistently across all 16 changed module, CI, Docker, and documentation files, with no stale Go 1.26.5 pins found. The exact head resolves successfully with Go 1.26.6, and the diff introduces no in-scope correctness issues. Source: Codex reviewer (exact backend model ID not supplied); Claude verifier (exact backend model ID not supplied); openclaw-agent/cliproxy/gpt-5.6-sol is orchestration-only and not reviewer evidence.

Validated zero-blocker Codex/Sol precheck evidence was promoted to final because Phase 2 (Sonnet/Opus) is temporarily disabled. This is Codex/Sol-only final validation, not Codex + Sonnet/Opus coverage.

Review provenance

  • Codex reviewers: gpt-5.6-sol — general (completed)
  • Verifier: gpt-5.6-sol — verifier
  • Sonnet/Opus: not run (Phase 2 disabled — temporary Codex/Sol-only final)
  • Secondary pass: disabled (temporary_phase2_sonnet_disable)

@lklimek
lklimek disabled auto-merge August 25, 2026 12:15
@lklimek
lklimek merged commit 0a7a33e into v1.7-dev Aug 26, 2026
35 of 38 checks passed
@lklimek
lklimek deleted the chore/bump-go-1.26.6 branch August 26, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants