chore(deps): bump Go to 1.26.6 - #1417
Conversation
govulncheck fails identically on v1.7-dev and every open PR branch (#1412, #1411, #1410) with 6 Go standard-library findings, all "Found in: go1.26.5 / Fixed in: go1.26.6": - GO-2026-6218 (net/url) - GO-2026-6091 (html/template) - GO-2026-6090 (crypto/tls) - GO-2026-6089 (net/http, x2) - GO-2026-5972 (encoding/asn1) Reachable from our TLS/RPC/HTTP server and Dash Core client paths (same call sites as PR #1395). Bumping the pinned toolchain from 1.26.5 to 1.26.6 turns govulncheck green everywhere at once and unblocks #1412, #1411, #1410. Mirrors PR #1395's pattern (1.26.4 -> 1.26.5): pure patch-release toolchain swap, no language/API changes, same 16 files touched (go.mod, CI workflow go-version pins, Dockerfiles, docs). Verified locally with go1.26.6: go build ./... succeeds, and govulncheck ./... reports 0 vulnerabilities (down from 6). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RoXmbFrVf1BqVW1BHZv6Va
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Final review complete — no blockers (commit 66fc928) |
thepastaclaw
left a comment
There was a problem hiding this comment.
Final validation — Codex/Sol only (Phase 2 disabled)
The Go 1.26.6 toolchain bump is applied consistently across all 16 changed module, CI, Docker, and documentation files, with no stale Go 1.26.5 pins found. The exact head resolves successfully with Go 1.26.6, and the diff introduces no in-scope correctness issues. Source: Codex reviewer (exact backend model ID not supplied); Claude verifier (exact backend model ID not supplied); openclaw-agent/cliproxy/gpt-5.6-sol is orchestration-only and not reviewer evidence.
Validated zero-blocker Codex/Sol precheck evidence was promoted to final because Phase 2 (Sonnet/Opus) is temporarily disabled. This is Codex/Sol-only final validation, not Codex + Sonnet/Opus coverage.
Review provenance
- Codex reviewers:
gpt-5.6-sol— general (completed) - Verifier:
gpt-5.6-sol— verifier - Sonnet/Opus: not run (Phase 2 disabled — temporary Codex/Sol-only final)
- Secondary pass: disabled (
temporary_phase2_sonnet_disable)
TL;DR: Bumps the pinned Go toolchain from 1.26.5 to 1.26.6 across the repo (go.mod, CI workflows, Dockerfiles, docs) to clear six pre-existing Go standard-library vulnerability findings that
govulncheckcurrently reports onv1.7-devand on every open dependency-bump PR.Detailed discussion
This is a pure internal/CI change with no user-observable behavior — no
User story/Scenariosections.Issue being fixed or feature implemented
govulncheckfails identically onv1.7-devand on every open PR branch (#1412, #1411, #1410), independent of what each PR actually changes:All six are Go standard-library vulnerabilities (GO-2026-6218, 6091, 6090, 6089 x2, 5972), found at
go1.26.5and fixed atgo1.26.6. None live in any third-party module, so no dependency bump can fix them. They're reachable from our TLS/RPC/HTTP server and Dash Core client paths — the same call sites documented in #1395, which fixed the previous instance of this exact pattern (1.26.4 → 1.26.5).Confirmed via three independent dependency-review passes this session that the same six IDs, in the same order, are already present on a plain
v1.7-devpush with no dependabot involvement — this is blocking unrelated PRs, not something any of them introduced.What was done?
Bumped Go from 1.26.5 to 1.26.6 at every pin, mirroring #1395's file list exactly:
go.modDOCKER/Dockerfile,test/docker/Dockerfile,test/e2e/docker/Dockerfilego-versionin thebuild,check-generated,e2e,govulncheck,lint,releaseandtestsworkflows, and.github/actions/bls/action.ymlREADME.md,docs/tutorials/go.md,docs/tutorials/go-built-in.md,test/fuzz/README.mdPatch release only — no language or API changes.
How Has This Been Tested?
Locally, with the Go 1.26.6 toolchain:
CI on this PR exercises the full build, lint, unit and e2e suites on the new toolchain — that's the authoritative signal for anything this local run couldn't reach.
Breaking Changes
None. Go patch release; no language or standard library API changes.
Checklist:
For repository code-owners and collaborators only
Prior work
Attribution
🤖 Co-authored by Claudius the Magnificent AI Agent