ENH: add nansum - #879
Open
ushnah wants to merge 6 commits into
Open
Conversation
feat: add nansum
Contributor
|
@lucascolley I encouraged others in my company to contribute. Could you enable the CI workflows please? |
fix: update delegation
OmarManzoor
reviewed
Aug 4, 2026
OmarManzoor
left a comment
OmarManzoor
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the PR @ushnah
Comment on lines
+2358
to
+2361
| def test_scalar(self, xp: ArrayNamespace): | ||
| a = xp.asarray(1.0) | ||
| assert nansum(a) == 1.0 | ||
|
|
Contributor
There was a problem hiding this comment.
I think we can remove this test for this function.
Suggested change
| def test_scalar(self, xp: ArrayNamespace): | |
| a = xp.asarray(1.0) | |
| assert nansum(a) == 1.0 |
Comment on lines
2374
to
2383
| def test_xp(self, axis: int | None, expected_list: list[float], xp: ArrayNamespace): | ||
| a = xp.asarray([[4.0, xp.nan, 1.0], [2.0, 3.0, xp.nan]]) | ||
| res = nansum(a, axis=axis, xp=xp) | ||
| expected = xp.asarray(expected_list) | ||
| assert_equal(res, expected) | ||
|
|
||
|
|
||
| class TestNanMax: | ||
| def test_simple(self, xp: ArrayNamespace): | ||
| a = xp.asarray([[5, 3], [6, xp.nan]]) |
Contributor
There was a problem hiding this comment.
I think we can move the TestNanSum after TestNanMax at the end of the file as it is the latest one added.
test: adjust nansum regression coverage
OmarManzoor
approved these changes
Aug 4, 2026
OmarManzoor
left a comment
OmarManzoor
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thank you @ushnah
Contributor
|
CC: @lucascolley |
lucascolley
self-requested a review
August 4, 2026 13:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #789