Add Thrift V10 batch parameter wire model - #1602
Open
sreekanth-db wants to merge 2 commits into
Open
Conversation
Regenerate the Thrift bindings with batchParameters support and advertise V10 while preserving negotiated compatibility with older servers. Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>
![peco-review-bot[bot]](https://avatars.githubusercontent.com/in/3801177?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the Thrift V10 wire model required for native parameter batches. The generated bindings now expose
SPARK_CLI_SERVICE_PROTOCOL_V10and nestedbatchParameters, and OpenSession advertises V10 while preserving server negotiation to older supported versions.The bindings were regenerated with Apache Thrift 0.23.0 from the connector IDL proposed in https://github.com/databricks-eng/universe/pull/2357213, matching the backend contract introduced by https://github.com/databricks-eng/runtime/pull/195829.
Testing
mvn test -pl jdbc-core -Dtest=DatabricksThriftServiceClientTest,ProtocolFeatureUtilTest,ThriftV10WireModelTest -Ddependency-check.skip=true— 210 passedjdbc-coresuite — 3,594 passed, 88 skippedmvn clean install -DskipTests -Ddependency-check.skip=true— passedmvn spotless:applyandgit diff --check— passedisaac review --uncommitted— APPROVE, zero findingsAdditional Notes to the Reviewer
This PR adds protocol negotiation and generated wire models only. Native
executeBatch()routing, configuration, and result handling will follow separately.Most generated-file changes update the common generation date;
TExecuteStatementReqandTProtocolVersioncontain the substantive IDL changes.NO_CHANGELOG=true