Skip to content

Reintroduce code changes - #190

Merged
bklaing2 merged 10 commits into
masterfrom
reintroduce-code-changes
Jul 28, 2025
Merged

Reintroduce code changes#190
bklaing2 merged 10 commits into
masterfrom
reintroduce-code-changes

Conversation

@bklaing2

@bklaing2 bklaing2 commented Jul 28, 2025

Copy link
Copy Markdown
Member

Purpose

Re-introduce the code changes once the database migration has been completed

The following PRs must be merged int this order (this is PR 2 of 3):

  1. Revert code changes
  2. Re-introduce code changes
  3. Revamp settings screen

closes: Add github issue that originated this PR

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@bklaing2
bklaing2 requested a review from jrhoads July 28, 2025 00:44
@bklaing2 bklaing2 self-assigned this Jul 28, 2025
This was referenced Jul 28, 2025
@bklaing2
bklaing2 force-pushed the reintroduce-code-changes branch from ec5a4fb to 12f3622 Compare July 28, 2025 17:49
@bklaing2
bklaing2 merged commit 593cd40 into master Jul 28, 2025
2 checks passed
@bklaing2
bklaing2 deleted the reintroduce-code-changes branch July 28, 2025 17:51
bklaing2 added a commit that referenced this pull request Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants