Skip to content

user's ORCID iD links to ORCID instead of Profiles settings #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bklaing2 merged 1 commit into from
Jul 30, 2025
Merged

user's ORCID iD links to ORCID instead of Profiles settings #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/user.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ def orcid
end

def orcid_as_url
Rails.env.test? ? ENV["ORCID_URL"] + "/" + orcid : "https://orcid.org/" + orcid
ENV["ORCID_URL"] ? ENV["ORCID_URL"] + "/" + orcid : "https://orcid.org/" + orcid
end

def flipper_id
Expand Down
2 changes: 1 addition & 1 deletion app/views/settings/_show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<div class="col-md-9">
<div class="panel-body settings-container">
<h2 class="settings-name col-span-full"><%= @user.name %></h2>
<p class="settings-orcid-link col-span-full"><%= link_to @user.orcid_as_url, @user.orcid %></p>
<%= link_to @user.orcid_as_url, @user.orcid_as_url, class: "settings-orcid-link col-span-full" %>

<h3 class="settings-section-header col-span-full">Link Works to ORCID
<% if @user.orcid_search_and_link_access_token %>
Expand Down