Skip to content

make orcid uppercase - #204

Merged
bklaing2 merged 1 commit into
masterfrom
force-orcid-id-uppercase
Jul 31, 2025
Merged

make orcid uppercase#204
bklaing2 merged 1 commit into
masterfrom
force-orcid-id-uppercase

Conversation

@bklaing2

Copy link
Copy Markdown
Member

Purpose

ORCID iDs may be saved with a lowercase trailing x. This ensures that they are shown with capital Xs per ORCID

closes: Add github issue that originated this PR

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@bklaing2
bklaing2 requested a review from a team July 31, 2025 15:35
@bklaing2 bklaing2 self-assigned this Jul 31, 2025
@bklaing2
bklaing2 merged commit df3be4f into master Jul 31, 2025
2 checks passed
@bklaing2
bklaing2 deleted the force-orcid-id-uppercase branch July 31, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants