Skip to content

Upgrade: Rails 7.1 → 7.2 & Ruby 3.1.7 → 3.2.9 - #217

Merged
kaysiz merged 11 commits into
masterfrom
ks-rails-upgrade/7.2
Jan 27, 2026
Merged

Upgrade: Rails 7.1 → 7.2 & Ruby 3.1.7 → 3.2.9#217
kaysiz merged 11 commits into
masterfrom
ks-rails-upgrade/7.2

Conversation

@kaysiz

@kaysiz kaysiz commented Jan 6, 2026

Copy link
Copy Markdown
Member

Purpose

closes: Add github issue that originated this PR

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@kaysiz kaysiz self-assigned this Jan 6, 2026
@kaysiz
kaysiz requested a review from a team January 6, 2026 16:38
Comment thread config/initializers/inflections.rb
Comment thread Dockerfile
RUN apt-get update && \
apt-get upgrade -y -o Dpkg::Options::="--force-confold" && \
apt-get install ntp wget google-chrome-stable python-dev pkg-config fontconfig libpng-dev libjpeg-dev libcairo2-dev libfreetype6-dev -y && \
apt-get install ntp wget google-chrome-stable python3-dev pkg-config fontconfig libpng-dev libjpeg-dev libcairo2-dev libfreetype6-dev -y && \

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking, but I'm curious where Python Dev is used in this.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅 I am not sure, will check it out when I do consolidation of docker images

@jrhoads jrhoads left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened to the phrase model in this project?

@kaysiz

kaysiz commented Jan 26, 2026

Copy link
Copy Markdown
Member Author

What happened to the phrase model in this project?

@jrhoads it was used by the RandomController which we removed

@kaysiz
kaysiz merged commit 5cea514 into master Jan 27, 2026
2 checks passed
@kaysiz
kaysiz deleted the ks-rails-upgrade/7.2 branch January 27, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants