Mexico_census_aa2|validation failure fix - #2140
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds validation configuration, golden data, and counters for the Mexico subnational population statistics import. Specifically, it introduces validation rules in validation_config.json, adds several golden observation and summary report CSV files, includes counter files, updates mexico_places.csv to map 'MX' to country/MEX, and updates manifest.json to integrate these validation steps and output counters. I have no feedback to provide as there are no review comments and the changes appear correct.
091daea to
cce44b2
Compare
|
Counter folder not required in Github. Please remove the folder and all file @Ashwani725 |
…o_census_aa2/counters/mexico_census_data_counters_0.csv delete counter file as not required
…o_census_aa2/counters/mexico_census_data_counters_1.csv
…o_census_aa2/counters/mexico_census_data_counters_2.csv
2 participants
validation failure fix.
Testing done successfully. Added Golden Checks and counters.
Files added are : golden_data/, validation_config.json, mexico_places.csv, counters/