Support date-only version folders and increase scan limit in list_import_summaries - #2143
Open
rohitkumarbhagat wants to merge 3 commits into
Open
Conversation
Add regex matching for YYYY-MM-DD version folders and increase the scan limit to 1000 to support imports with large run histories.
rohitkumarbhagat
enabled auto-merge (squash)
August 6, 2026 15:59
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request increases the scan limit for import summaries from 100 to 1000 and introduces support for date-only version patterns (YYYY-MM-DD). The review feedback identifies a sorting bug that occurs when mixing underscore-separated and hyphen-separated date formats, as ASCII comparison will sort them incorrectly. It is recommended to normalize the separators in the sorting key to ensure correct ordering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
YYYY-MM-DDdate-only version folder naming inlist_import_summaries.pyalongside standard timestamp folders._SCAN_LIMITfrom100to1000to prevent truncation errors for imports with extensive run histories (e.g.scripts/entities:Schema).Verification
scripts/entities:Schemato verify recent version summaries are listed correctly.list_import_summaries_test.py../run_tests.sh -land unit tests.