Skip to content

Remediate CDC_Mortality_UnderlyingCause_SingleRace import - #2146

Open
shvngisingh wants to merge 2 commits into
datacommonsorg:masterfrom
shvngisingh:us_cdc_nodes
Open

Remediate CDC_Mortality_UnderlyingCause_SingleRace import#2146
shvngisingh wants to merge 2 commits into
datacommonsorg:masterfrom
shvngisingh:us_cdc_nodes

Conversation

@shvngisingh

Copy link
Copy Markdown
Contributor

Remediates the CDC_Mortality_UnderlyingCause_SingleRace import pipeline.

Fix Validation: Added the generated statvar schema MCF to the manifest import_inputs to resolve missing reference warnings.
Auto-refresh robustness: Stripped hardcoded year range suffixes from scripts and manifest file paths to dynamically support future years without manual renaming.
Telemetry: Configured telemetry counter CSV generation.

Tested in dev environment .
Bucket: link

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces validation configurations and golden data files for the FAO currency and exchange rate import, while also updating the US CDC single race import configuration, scripts, and documentation. The review feedback highlights a formatting issue in the newly added golden_observation.csv that could cause validation failures, and points out a documentation inconsistency in the README.md which is missing the newly introduced --output_counters argument.

Comment thread statvar_imports/us_cdc/single_race/README.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant