Repository navigation
fix(cli): filter out non-existent tables in BigQueryDbAdapter.search - #2388
Merged
Merged
Conversation
rafal-hawrylak
requested review from
apilaskowski and
mbiernacik
and removed request for
a team
October 18, 2026 07:18
apilaskowski
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In BigQuery, when a dataset is dropped with
DROP SCHEMA ... CASCADE, its tables remain visible inregion-<location>.INFORMATION_SCHEMA.COLUMN_FIELD_PATHSduring BigQuery's 7-day time-travel window even thoughtables.getreturns404 Not Found.BigQueryDbAdapter.searchmapsCOLUMN_FIELD_PATHSresults throughthis.table(...), which returnsnullwhengetMetadata()encounters404 notFound. Previously,search()did not filter outnullentries (unlikeBigQueryDbAdapter.tables()), causingsearch()to includenullelements for recently dropped datasets/tables and breaking//tests/integration:bigquery.spec > search.Testing
./scripts/lintbazel test //cli/api:dbadapters/bigquery_testbazel test //tests/integration:bigquery.spec