Repository navigation
Fix/lsds calling env - #522
Merged
Merged
Conversation
timcadman
force-pushed
the
fix/lsds-calling-env
branch
from
October 30, 2026 08:24
fcd5be6 to
0f71904
Compare
timcadman
marked this pull request as ready for review
October 30, 2026 09:11
StuartWheater
approved these changes
Oct 30, 2026
StuartWheater
left a comment
StuartWheater
left a comment
Member
There was a problem hiding this comment.
- Change looks correct
- Test also looks correct and passes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
ds.ls didn't work with DSLite. lsDS always searched .GlobalEnv, which under DSLite is the client's R session, so it listed the client's objects and missed those assigned on the DSLite server.
What's changed
lsDS now searches the environment it's called from. On Opal and Armadillo that is still .GlobalEnv, so behaviour there is unchanged. On DSLite it is the DSLite session, so the same objects are returned. environment.searched reports "DSLiteEnv_" under DSLite.