Repository navigation
ci: Add required CI check - #234
Merged
Merged
Conversation
Pull requests could merge with a red or missing build because no check was required. The existing manifest validation only ran when plugins/ changed. Call the shared ci-basic workflow from a job named ci so the check reports as ci / Build and test on every pull request. scripts/ci-check validates every plugin manifest against the schema and parses index.yaml, offline. JSON Schema validation needs a Python library, which Bash cannot replace.
andrewb3000
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull requests can merge with a red or missing build, because no check is required to pass. This adds a
cijob that calls the shared ci-basic workflow, so every pull request reportsci / Build and test, ready for infra to require.What it runs:
scripts/ci-checkvalidates every manifest inplugins/against the schema, parsesindex.yamland compilesscan-upstream-releases.py, all offline. It uses a Python venv with pinnedjsonschemaandPyYAMLbecause Bash cannot validate JSON Schema.Left alone:
validate-pr.yamlkeeps checking download URLs and checksums for changed manifests.ci-basicfinds nothing to build here, so only the script runs.Required checks: none.
Fixes #233