Don't rewrite ~/.myclirc quotes on /dsn save - #2094
Merged
Merged
Conversation
The user's own quoting, or lack of quoting, could be rewritten if saving or deleting a DSN alias via the REPL. If the dotfile is kept under revision control, this can create needless churn. Moves implementation of manual triplequoting from favorite queries to the ConfigObj subclass. The previous implementation only guaranteed maintaining triplequotes within favorite queries, during a favorite queries save. There is one limitation explained in the docstring: the style of any triplequoted multiline value cannot be maintained perfectly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The user's own quoting, or lack of quoting, could be rewritten if saving or deleting a DSN alias via the REPL. If the dotfile is kept under revision control, this can create needless churn.
Moves implementation of manual triplequoting from favorite queries to the
ConfigObjsubclass. The previous implementation only guaranteed maintaining triplequotes within favorite queries, during a favorite queries save.There is one limitation explained in the docstring: the style of any triplequoted multiline value cannot be maintained perfectly.
xref #2092
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).