Complete all Jinja2 keys after --<tab> in /f - #2095
Merged
Merged
Conversation
Because -- means "end of options", there was a slight ambiguity for favorite completions if <tab> was pressed immediately after --. We should see all possible key names, as scraped from the Jinja2 template for the favorite query. Whereas if there is an intervening space: "-- <tab>", no key-name completions should be offered. This fixes favorite parameter completion so that completions are equally visible after "-<tab>", "--<tab>", and "--<partial><tab>". The change can be included under a pending changelog entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Because
--means "end of options", there was a slight ambiguity for favorite completions if<tab>was pressed immediately after--. We should see all possible key names, as scraped from the Jinja2 template for the favorite query.Whereas if there is an intervening space:
-- <tab>, no key-name completions should be offered.This fixes favorite parameter completion so that completions are equally visible after
-<tab>,--<tab>, and--<partial><tab>.The change can be included under a pending changelog entry.
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).