Skip to content

fix: correct scroll offset when clearing search in tree view #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bosiakov merged 1 commit into from
Apr 2, 2026
Merged

fix: correct scroll offset when clearing search in tree view #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ui/tab_treeview.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,12 +191,20 @@ func renderTreeView(gtx C, app *appstate.State, theme *material.Theme) D {
if targetIndex < len(app.Tree.Nodes) {
app.Tree.SelectedNode = targetIndex
app.Tree.SelectedNodePath = ""

// Directly position list to show the selected item.
// Height caches are empty after tree rebuild, so
// calculateSmartScrollPositionVariable would use inaccurate
// fallback heights. Place the item a few rows from the top.
first := max(targetIndex-treeRestoreContextRows, 0)
app.Tree.List.Position.First = first
app.Tree.List.Position.Offset = 0
}

selectedTreeNode = app.Tree.SelectedNode
app.StoreMu.Unlock()

needScrollToSel = true // Update local var so scroll runs in the SAME frame
needScrollToSel = true
app.NeedScrollToSel = true

app.Tree.NeedInitialSel = false
Expand Down
Loading