Repository navigation
Fix accessible labels for Composer inputs - #29
Merged
WaylandYang merged 4 commits intoOct 15, 2026
Merged
Conversation
Signed-off-by: Maya Kid <29959320+Maya-Kid@users.noreply.github.com>
Signed-off-by: Maya Kid <29959320+Maya-Kid@users.noreply.github.com>
…t split Signed-off-by: Maya Kid <29959320+Maya-Kid@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Composer applied HTML attributes only to its outer div, so callers could not explicitly name its textarea or associate an external label with it.
What changes
Add a constrained
textareaPropsAPI for the input'sid,aria-label,aria-labelledby, andaria-describedby, preserving wrapper attributes and the controlled input and keyboard behavior. Give the Composer examples and Agent Workspace input explicit message labels and document external label association.How it was checked
npm run docs,npm run typecheck, andnpm run buildpass on Node 26.3.0.labelassociation,aria-labelledbyprecedence, descriptions, wrapper attributes, and the real Agent Workspace input.canSubmit={false}, stop, Backspace-at-start, and multiline sizing. No browser errors.Before review
git commit -s)npm run typecheckandnpm run buildpass/dev/examplesreports0 failedsrc/examples/and its page incontent/solid/