Skip to content

test: tolerate Codex daemon reconciliation race #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
defangdevs merged 1 commit into from
Oct 23, 2026
Merged

test: tolerate Codex daemon reconciliation race #917

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion tests/sessions.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -954,7 +954,13 @@ in
old_helper_pid = machine.succeed(
tmux('display -p -t "=helper:" "#{pane_pid}"')
).strip()
machine.succeed(tmux("kill-session -t =helper"))
# The direct wrapper checks above stop the same user-wide Codex daemon
# that helper supervises. Its pane can therefore disappear between the
# PID read and this deliberate kill; wait for reconciliation to provide a
# live pane instead of failing in that sub-second window.
machine.wait_until_succeeds(
tmux("kill-session -t =helper"), timeout=60
)
helper_restart = machine.wait_until_succeeds(
tmux('list-panes -t "=helper" -F "#{pane_pid} #{pane_start_command}"')
+ f" | grep -v '^{old_helper_pid} '",
Expand Down
Loading