[defangdevs]

Fixes #921. Symptom: the guest logged agent-box-defang-cli.service:18: Unknown key 'StartLimitIntervalSec' in section [Service], ignoring. so the 10min/5-burst retry limit was never applied.

Moved both keys to unitConfig. The other occurrence (nixpkgs-cache unit) already used unitConfig. Regenerated the module and the golden fixture; native expected is unchanged.

🤖 Generated with Claude Code

https://claude.ai/code/session_017udTN8573h7eBdfWNL15dT

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 6ff289e8-4c84-4a11-9a16-0cb17c2c45c7

📥 Commits

Reviewing files that changed from the base of the PR and between c156fde and ec8f39e.

📒 Files selected for processing: 3

• modules/agent-box.nix
• modules/agent-box.nix.in
• tests/golden/vm/units/agent-box-defang-cli.service

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The Defang CLI service’s StartLimitIntervalSec and StartLimitBurst settings move from serviceConfig to unitConfig. The golden systemd unit places both settings under [Unit].

Changes: Defang CLI start limits

Layer / File(s)	Summary
Move start limits to unit configuration modules/agent-box.nix, modules/agent-box.nix.in, tests/golden/vm/units/agent-box-defang-cli.service	The module and template declare both start-limit settings in unitConfig. The golden unit places them under [Unit] and removes them from [Service].

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: lionello

Merge Risk: ⚪ Minimal · up to ec8f3

No actionable merge-blocking risk remains.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: moving the systemd StartLimit* settings to the [Unit] section.
Description check		The description directly explains the systemd warning, the configuration fix, and the regenerated files. It is related to the changeset.
Linked Issues check		Issue #921 requires the Defang CLI rate-limit settings to use unitConfig and requires regeneration of the assembled module. The diff removes StartLimitIntervalSec = "10min" and `StartLimitBurst = …
Out of Scope Changes check		The changes are limited to the linked issue. They update the Defang CLI systemd declaration in the template and generated module, plus the matching golden fixture. The changes support placement of the…
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…

Full details: Linked Issues check

Explanation

Issue #921 requires the Defang CLI rate-limit settings to use unitConfig and requires regeneration of the assembled module. The diff removes StartLimitIntervalSec = "10min" and StartLimitBurst = 5 from serviceConfig in both modules/agent-box.nix.in and the generated modules/agent-box.nix. It adds both settings to unitConfig. The regenerated golden unit places both directives under [Unit] and removes them from [Service]. The PR description also records that the other occurrence already used unitConfig.

Full details: Out of Scope Changes check

Explanation

The changes are limited to the linked issue. They update the Defang CLI systemd declaration in the template and generated module, plus the matching golden fixture. The changes support placement of the systemd rate-limit directives and introduce no unrelated behavior or files.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud