ci: make Ready gate fail when required jobs fail - #780
Open
omercnet wants to merge 2 commits into
Open
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
🐕 Review complete — View session on Shuni Portal 🐾 |
![shuni-bot[bot]](https://avatars.githubusercontent.com/in/2536750?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🐕 Shuni's Review
Makes the 🚀 Ready gate run with if: always() and fail explicitly when any needs job reports failure/cancelled, so a skipped gate can no longer auto-satisfy branch protection.
Logic checks out: needs.*.result is valid in a step-level if, contains() does exact element matching, and treating skipped as a pass is correct here since pr-title-check is intentionally skipped on push to main. build/eslint/gitleaks/unit-test have no if: and no needs, so they can't be silently skipped. ci.yml is the only workflow with this gate pattern — nothing else to update.
No blocking issues — good bones! One 💡 NIT inline. Woof!
Co-authored-by: shuni-bot[bot] <251468265+shuni-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
🚀 Readygate (the only required status check onmain) has noif: always(), so when any upstream job fails the gate is skipped —and GitHub treats a skipped required check as satisfied. Combined with auto-approve + auto-squash, PRs merge over red CI (e.g. #776). This makes the gate
run always and fail explicitly if any required job failed or was cancelled.