feat(mgmt): load external groups scoped to a specific SSO config - #783
feat(mgmt): load external groups scoped to a specific SSO config#783dorsha wants to merge 2 commits into
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
|
🐕 Review complete — View session on Shuni Portal 🐾 |
🐕 Suggested ReviewersThe review assignment prioritizes breadth of file coverage and contributor expertise, selecting contributors who have engaged with different parts of the codebase affected by this PR to ensure thorough review.
Suggested by Shuni based on git history and PR context. Names are not @-mentioned to avoid notifying anyone — request a review from whoever fits best. |
There was a problem hiding this comment.
🐕 Shuni's Review
Adds an optional trailing ssoId filter to the three group-loading management methods and declares source/ssoId on the Group type.
Sniffed out 0 issues. Good bones! 🦴
Checked the things that could actually break: the new trailing optional params are backwards compatible, ssoId: undefined is dropped by JSON serialization (and matches the existing pattern in lib/management/user.ts), and the pre-existing toHaveBeenCalledWith assertions still pass since Jest uses toEqual semantics that ignore undefined properties.
Two non-blocking notes, no action required: only loadAllGroups got an ssoId test, and the README group section still shows the pre-ssoId signatures. Woof!
Declared coverage: FULL — 3/3 changed files reviewed.
…lter # Conflicts: # lib/management/types.ts
Related Issues
Required for:
https://github.com/descope/etc/issues/17382
Related PRs
Upstream PRs
In a Nutshell
ssoIdparam on the three group-loading methodsGrouptype gainsssoIdssoIdis dropped from the JSON body when undefinedDescription
Adds SSO-config scoping to
loadAllGroups,loadAllGroupsForMemberandloadAllGroupMembers, matching the new backendssoIdfilter. The reserved iddefault_ssoidtargets the tenant's default SSO configuration.Must
🤖 Generated with Claude Code