Repository navigation
fix(vue): preserve Steps and Select caller events - #169
Merged
Merged
Conversation
Wire Steps root emits and compose ordinary same-key native listeners before core handlers in component-scoped wrappers. Preserve native listener arrays, identity deduplication, asChild behavior and Select presence lifecycle. Add focused listener and runtime regressions without changing versions, dependencies or workflows.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
elonehoo
marked this pull request as ready for review
November 5, 2026 12:01
elonehoo
added a commit
that referenced
this pull request
Nov 5, 2026
Synchronize all four public UI packages at0.0.3 and consume verified core0.3.4 artifacts. Preserve the Vue Steps/Select event fixes from #169 and update the frozen lockfile and exact-core gate. BREAKING CHANGE: Core0.3.4 changes Steps roving Tab order, keyboard navigation and completion roles, and Select default composite focus ownership. Existing Vue wrapper .once.prevent cancellation remains limited; capture/passive semantics are unchanged. Migration and known-limit notes: https://github.com/destyler/ui/blob/v0.0.3/docs/releases/0.0.3.md The scoped changelogithub configuration renders these notices in the generated release body. Actual-generator proof and all final-head CI/reviews passed. No package publication is performed by this merge. Pull request: #170
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains the exact reviewed 15-file candidate. Shared factory/Dynamic, core dependencies, versions, lockfiles and workflows are unchanged. It does not publish a release. The separate core Steps/Select keyboard and focus changes are not included; this PR's existing CI uses the unchanged published core 0.3.3 pins.
Validation
Known limits
onClickOnce/onKeydownOnceremain separate native registrations. Wrapper.once.preventcan still run after the core action on the first event. Nine exploratory Steps failures remain unresolved; six Select tests explicitly characterize that existing limit. Capture/passive semantics are not rewritten.defaultPrevented.selectedOptionscache. The corrected local oracle verifies every option flag and callback history; native emulator regressions retain that failure and additional multi/disabled/empty FormData limitations. No product workaround or dependency patch is included.The existing checks are green and squash merge is now authorized. Release preparation will separately align the chosen published core version, catalog/lockfile, exact-core gate, synchronized UI versions and migration notes before a release tag is pushed. No version is published by this PR itself.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Note
Medium Risk
Touches event wiring on heavily used Select/Steps parts and changes listener order/cancellation semantics app code may rely on; mitigated by extensive regression tests but not full browser/a11y coverage.
Overview
Fixes Vue Select and Steps wrappers so parent attrs/listeners compose correctly with core machine props instead of being dropped or running in the wrong order.
Both libraries get shared composables (
useSelectPartProps,useStepsTriggerProps) thatmergePropscore +useAttrs(), setinheritAttrs: false, and rebuild same-key handlers so caller listeners run before core, with Vue-style listener arrays (vetoes, dedup, reactive swap/remove, errors, asChild). Select parts (Trigger, Content, Item, Label, ClearTrigger) and Steps triggers (Trigger, Next, Prev) bind throughgetMergedProps(); Select.Content still merges Presence first, then attrs.Steps.Root now
defineEmitsand passesemitsintouseSteps, sostepChange,update:modelValue, andstepCompletereach consumers.Adds large listener-contract and runtime unit suites (~320 cases) for ordering, cancellation, controlled state, lazy mount, and Presence cleanup; documents limits for
onClickOnce/ modifier keys.Reviewed by Cursor Bugbot for commit 2c7d304. Bugbot is set up for automated code reviews on this repo. Configure here.