Skip to content

fix(calendar): forward outside-day opt-in (0.0.5 preparation) - #172

Merged
elonehoo merged 2 commits into
mainfrom
fix/calendar-outside-days-0.0.5
Nov 10, 2026
Merged

elonehoo merged 2 commits into
mainfrom
fix/calendar-outside-days-0.0.5

Conversation

@elonehoo

@elonehoo elonehoo commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

Draft: not ready to merge or publish

Depends on destyler/destyler#365 and the published Calendar 0.3.5 package. The catalog/lockfile currently still resolve ^0.3.4. Before release, raise Calendar's minimum dependency to ^0.3.5 and regenerate the lockfile against the real published package. Do not ship this draft as-is.

Changes

  • Forward allowOutsideDays in React, Solid, Svelte Root prop splits and Vue public props/defaults.
  • Expose optional hook types without enabling the option by default.
  • Prepare synchronized UI 0.0.5 manifests and document click/range-hover navigation semantics.
  • Add eight static adapter-contract tests to the existing test:ci pipeline without changing existing browser gates.

Verified

  • 8 static Calendar adapter contract tests passed.
  • 383 publish-policy tests passed; offline publish scope verifies 9 workspaces / 4 public packages.
  • git diff --check passed. Pinned pnpm 10.28.0 frozen installation, all four package builds and all four framework type checks passed (Svelte: 0 errors, 0 warnings). Solid SSR 90/90 and Svelte SSR 145/145 passed. Changed-file lint has 0 errors and 4 warnings (including pre-existing warnings/ignored framework files). These checks use the currently released core 0.3.4, so they prove compatibility and prop wiring, not execution of the new core option.
  • No local browser was launched. This is not visual acceptance for designs.

No packages or production sites have been published.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Note

Medium Risk
Calendar selection/focus semantics change when consumers opt in, and the release hard-requires aligned core 0.3.5 types; static tests do not cover runtime interactions.

Overview
Prepares UI 0.0.5 and threads an opt-in allowOutsideDays prop through Calendar Root / useCalendar in React, Vue, Solid, and Svelte. Omitted or false keeps today’s behavior; enabling it needs @destyler/calendar ^0.3.5, which the prod catalog and lockfile are bumped to across @destyler/*.

Framework changes are mostly wiring: whitelist/split props, public hook/types (Vue RootProps + allowOutsideDays: undefined defaults), with no adapters defaulting the flag to true.

Release notes in docs/calendar-outside-days.md spell out click/range-hover navigation when outside-month days are selectable. test:calendar-contract (wired into test:ci) adds source-level contract checks; core-compat gates now target 0.3.5. Browser behavior is still explicitly out of scope for these tests.

Reviewed by Cursor Bugbot for commit 1a603c1. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel

vercel Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
destyler-ui Error Error Nov 11, 2026 1:50am UTC
destyler-ui-dev Ready Ready Preview Nov 11, 2026 1:50am UTC

@elonehoo
elonehoo marked this pull request as ready for review November 10, 2026 01:35
@elonehoo
elonehoo merged commit f2b03d2 into main Nov 10, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant