Repository navigation
fix: include quote and image previews in notification API - #1004
Open
ricardovfreixo wants to merge 1 commit into
Open
ricardovfreixo wants to merge 1 commit into
ricardovfreixo wants to merge 1 commit into
Conversation
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The web inbox already shows the recipient's quoted commit and images on starred commits. The signed mobile notification API uses the same resources, but never loads those relations, so native clients cannot render those previews.
Companion mobile draft: NativePHP/dev-null-app#79 (refs NativePHP/dev-null-app#71). It links this API change and the independent rank-metadata PR #836.
Changes
GET /api/v1/notificationsandGET /api/v1/notifications/{notification}/group.This is an API-only companion change: mobile quote/image previews require this to be merged and deployed to the backend they connect to. Level/rank details are a separate dependency already covered by #836; this PR deliberately does not duplicate that work.
Verification
composer test: passed, including lint/Rector, PHPStan/TypeScript, type coverage and frontend tests.pest --parallel --ci --coverage --exactly=100.0run also passed.Tests ran against a dedicated local test database. No production data or runtime deployment was changed.
Complete mobile delivery / remaining gates
This API-only PR is independently testable with the local verification above; no runtime deployment was performed and no claim about current remote CI is made.
29a838d, including feat: clickable links and preview cards for links in commits #73/Original post remains in activity log after deleting my reply #75/feat: add commits and replies tabs to profiles #76.f06d13ccc80e597b86600e442a2dd2407ac0ab5e.28753b7ea337349243330c1f531ed61f386a2c6d.The app's tracked manifest/lock include both source refs; no hidden vendor/generated-shell patches or local path repositories are required. Its full PHP suite passed 1,297 tests / 12,591 assertions after installation from the public ZIP archives. The SDK changes address separate native Log reselect, return-to-existing-feed and saveable-pane-state behavior; they are not part of this API diff and do not block testing it independently.
The app draft contains dependency/setup instructions, the required
php -d memory_limit=1GAndroid rebuild commands, all companion links, and outstanding native compilation/JVM/instrumentation/phone/screenshot gates. PHP checks do not prove native pixel-offset restoration or the reported idle behavior. Full quote/image/rank parity still requires this API and #836 to be merged and deployed; opening the PRs does not deploy them.