Skip to content

feat: make stargazers have a hovercard #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sulimanbenhalim wants to merge 1 commit into
base: production
Choose a base branch
from
Open

feat: make stargazers have a hovercard #1204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 20 additions & 17 deletions resources/js/components/commit-stargazers-dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import {
DialogTrigger,
} from '@/components/ui/dialog';
import { UserAvatar } from '@/components/user-avatar';
import { UserPreview } from '@/components/user-preview';
import { exactCountTitle, formatCount } from '@/lib/numbers';
import { show } from '@/routes/user';
import type { Commit, CursorPaginated, User } from '@/types';
Expand Down Expand Up @@ -85,24 +86,26 @@ export function CommitStargazersDialog({
<ul data-test="stargazers" className="-mx-2">
{stargazers.map((stargazer) => (
<li key={stargazer.id}>
<Link
href={show(stargazer)}
onClick={() => setOpen(false)}
className="flex items-center gap-3 rounded-md px-2 py-2 transition-colors hover:bg-accent"
>
<UserAvatar
user={stargazer}
className="size-9"
/>
<span className="min-w-0">
<span className="block truncate text-sm font-medium">
{stargazer.name}
</span>
<span className="block truncate font-mono text-[13px] text-muted-foreground">
@{stargazer.handle}
<UserPreview user={stargazer} className="block">
<Link
href={show(stargazer)}
onClick={() => setOpen(false)}
className="flex items-center gap-3 rounded-md px-2 py-2 transition-colors hover:bg-accent"
>
<UserAvatar
user={stargazer}
className="size-9"
/>
<span className="min-w-0">
<span className="block truncate text-sm font-medium">
{stargazer.name}
</span>
<span className="block truncate font-mono text-[13px] text-muted-foreground">
@{stargazer.handle}
</span>
</span>
</span>
</Link>
</Link>
</UserPreview>
</li>
))}
{loading &&
Expand Down