feat(data-inspector): deep link to a data source - #152
Merged
Conversation
Carry the shareable workbench state in the URL hash instead of the query string, and add a live hashchange listener so back/forward and manual edits re-apply source, query, filters, and auto-rerun. Keeps a copied link reproducing an exact result while leaving the query string free for the server handshake token. Focus a source when mounted in a hub: subscribe to the devframe:docks:active slot and select the source named in an activation's params.sourceId, converging once it registers — mirroring how the terminals dock focuses a session. Document deep linking as a cross-devframe pattern: a new guide page leading with in-hub dock activation and covering standalone URL-hash links, plus sections on the Data Inspector and Terminals plugin pages.
✅ Deploy Preview for devfra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make deep-linking to a specific data source first-class in the Data Inspector, and document deep linking as a cross-devframe pattern.
Data Inspector
#source=…&query=…instead of the query string, so a copied link reproduces an exact result while leaving the query string free for the server handshake token (?devframe_auth_token=, scrubbed on read).hashchangelistener re-applies the full state on back/forward and manual address-bar edits; writes stay onreplaceStateso keystrokes never stack history entries.devframe:docks:activeshared-state slot and selects the source named in an activation'sparams.sourceId, converging once it registers — mirroring how the terminals dock focuses a session. Inert outside a hub.Docs
docs/guide/deep-linking.md(registered in the Guide sidebar) — leads with in-hub dock activation, then standalone URL-hash links, with one mermaid diagram; cites Terminals and Data Inspector as the reference examples.#id=<sessionId>hash link.Verification
pnpm build,pnpm typecheck,pnpm lint, andpnpm docs:buildall pass (VitePress dead-link checking included).This PR was created with the help of an agent.